clementine, qjson, liblastfm: fix build failure with cmake 4 by drawbu · Pull Request #452435 · NixOS/nixpkgs

drawbu · 2025-10-16T01:00:54Z

Fix clementine build failure and its dependencies on newer cmake 4.

Tracking: Build Failures with CMake 4 #445447

Things done

Add a 👍 reaction to pull requests you find important.

drawbu · 2025-10-16T20:27:12Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 452435
Commit: 74f5641755f28fb1fa05a5b737b46bbba3a1fb0b

`x86_64-linux`

✅ 4 packages built:

clementine
libsForQt5.liblastfm (plasma5Packages.liblastfm)
libsForQt5.qjson (plasma5Packages.qjson)
tests.pkgs-lib

Sigmanificient · 2025-10-18T19:55:41Z

This seems to be a sandbox related issue

drawbu · 2025-10-19T00:38:39Z

Ok, I dont own a macOS machine, so I'll have to run nixpkgs-review a few times to debug this, so I'll mark this PR as draft while not ready.

- CMake 4 is no longer retro compatible with versions < 3.5

- CMake 4 is no longer retro compatible with versions < 3.5 - Policy CMP0053 may not be set to OLD behavior because this version of CMake no longer supports it. The policy was introduced in CMake version 3.1.0, and use of NEW behavior is now required.

Sigmanificient · 2025-10-19T01:29:35Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 452435
Commit: e5cb53f643429ce434a43b090b76c4677f34670c (subsequent changes)
Merge: f2e260a1077933949e15d337a470a93e71dda4d5

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18623400204

`x86_64-linux`

✅ 3 packages built:

clementine
libsForQt5.liblastfm (plasma5Packages.liblastfm)
libsForQt5.qjson (plasma5Packages.qjson)

`aarch64-linux`

✅ 3 packages built:

clementine
libsForQt5.liblastfm (plasma5Packages.liblastfm)
libsForQt5.qjson (plasma5Packages.qjson)

`x86_64-darwin` (sandbox = relaxed)

✅ 2 packages built:

libsForQt5.liblastfm (plasma5Packages.liblastfm)
libsForQt5.qjson (plasma5Packages.qjson)

`aarch64-darwin` (sandbox = relaxed)

✅ 2 packages built:

libsForQt5.liblastfm (plasma5Packages.liblastfm)
libsForQt5.qjson (plasma5Packages.qjson)

LordGrimmauld

Diff looks reasonable. I did not check the build, i trust the nixpkgs-review done by @Sigmanificient for that.

I did double-check upstream for potential better fixes, and came back empty-handed. Tbh i am surprised this is even possible to resurrect this easily, these dependencies are quite crusty. Qt5 is EOL, liblastfm is abandoned upstream, and qjson is tracking a fork of the original (abandoned) sourceforge repository (we should maybe fix the meta homepage for that, but that is a different orthogonal change).

Personally i'd just remove all of this stuff, but there is no harm in fixing it even if it is being removed in the near future, the work is already done. Thank you!

LordGrimmauld · 2025-10-19T07:05:24Z

pkgs/applications/audio/clementine/default.nix

+    # CMake 3.0.0 is deprecated and no longer supported by CMake > 4
+    # https://github.com/NixOS/nixpkgs/issues/445447
+    substituteInPlace 3rdparty/{qsqlite,qtsingleapplication,qtiocompressor,qxt}/CMakeLists.txt \
+      cmake/{ParseArguments.cmake,Translations.cmake}                                          \
+      tests/CMakeLists.txt gst/moodbar/CMakeLists.txt                                          \
+      --replace-fail                                                                           \
+        "cmake_minimum_required(VERSION 3.0.0)" \
+        "cmake_minimum_required(VERSION 3.10)"
+    substituteInPlace 3rdparty/libmygpo-qt5/CMakeLists.txt --replace-fail \
+      "cmake_minimum_required( VERSION 3.0.0 FATAL_ERROR )" \
+      "cmake_minimum_required(VERSION 3.10)"
+    substituteInPlace CMakeLists.txt --replace-fail \
+        "cmake_policy(SET CMP0053 OLD)" \
+        ""


Damn! This is a lot... Kudos for going to these lengths. With multiple 3rd-party deps i did accept the cmake flag as a shortcut in the past, but this is certainly a way XD

LordGrimmauld · 2025-10-19T07:08:50Z

pkgs/applications/audio/clementine/default.nix

    sed -i CMakeLists.txt \
      -e 's,libprotobuf.a,protobuf,g'
+
+    # CMake 3.0.0 is deprecated and no longer supported by CMake > 4


Upstream did some cmake cleanup in clementine-player/Clementine@fe3599c, but did not actually bump the cmake_minimum_required, so an update won't fix and there is no commits to fetch.

clementine-player/Clementine#7402 does technically exist, but the upstream CI failing across the board is concerning. It may still make sense to link it, but substituteInPlace really does seem like it is the best way.

LordGrimmauld · 2025-10-19T07:10:33Z

pkgs/development/libraries/liblastfm/default.nix

    })
  ];

+  # CMake 2.8.6 is deprecated and no longer supported by CMake > 4


liblastfm is dead upstream, so makes sense to just substitute and be done with it.

LordGrimmauld · 2025-10-19T07:14:06Z

pkgs/development/libraries/qjson/default.nix

    sha256 = "1f4wnxzx0qdmxzc7hqk28m0sva7z9p9xmxm6aifvjlp0ha6pmfxs";
  };

+  # CMake 2.8.8 is deprecated and no longer supported by CMake > 4


I am surprised this even still builds... Upstream claims build failures e.g. in flavio/qjson@1105e53...

That said, upstream does not have a fix for cmake 4 yet, so a substitute seems to make sense.

This comment was marked as outdated.

Sign in to view

nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 16, 2025

nix-owners bot requested a review from ttuegel October 16, 2025 01:06

This comment was marked as outdated.

Sign in to view

Sigmanificient mentioned this pull request Oct 16, 2025

Tracking: Build Failures with CMake 4 #445447

Open

drawbu force-pushed the clement/cmake4-build-clementine branch from a116a20 to 74f5641 Compare October 16, 2025 20:21

This comment was marked as outdated.

Sign in to view

This comment was marked as duplicate.

Sign in to view

drawbu marked this pull request as draft October 19, 2025 00:38

drawbu added 3 commits October 18, 2025 17:49

liblastfm: fix build failure with cmake 4

1dfb24c

- CMake 4 is no longer retro compatible with versions < 3.5

drawbu force-pushed the clement/cmake4-build-clementine branch from 74f5641 to e5cb53f Compare October 19, 2025 00:49

This comment was marked as duplicate.

Sign in to view

drawbu marked this pull request as ready for review October 19, 2025 01:28

Sigmanificient requested a review from LordGrimmauld October 19, 2025 01:33

LordGrimmauld approved these changes Oct 19, 2025

View reviewed changes

nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 19, 2025

vcunat added this pull request to the merge queue Oct 19, 2025

Merged via the queue into NixOS:master with commit 69351b8 Oct 19, 2025
29 of 32 checks passed

drawbu deleted the clement/cmake4-build-clementine branch October 19, 2025 17:39

Uh oh!

Comments

Conversation

drawbu commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

drawbu commented Oct 16, 2025

nixpkgs-review result

x86_64-linux

Uh oh!

This comment was marked as outdated.

Sigmanificient commented Oct 18, 2025

Uh oh!

This comment was marked as duplicate.

drawbu commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as duplicate.

This comment was marked as duplicate.

Sigmanificient commented Oct 19, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin (sandbox = relaxed)

aarch64-darwin (sandbox = relaxed)

Uh oh!

LordGrimmauld left a comment

Choose a reason for hiding this comment

Uh oh!

LordGrimmauld Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

LordGrimmauld Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

LordGrimmauld Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

LordGrimmauld Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

drawbu commented Oct 16, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

drawbu commented Oct 19, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin` (sandbox = relaxed)

`aarch64-darwin` (sandbox = relaxed)