Conversation
|
The diff looked good but I hadn't tested the PR. Undoing the accidental approval. |
|
simalar tests to before: on nixos-unstable (addf7cf) nixos-unstable...tiiuae:nixpkgs:cosmic-stable The revert and first cherry-pick are needed for cross-compiled rust settings see #465948 The cosmic DE (cosmic stable) builds on aarch64 (native), aarch64 (cross), and x86-64. |
thefossguy
left a comment
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 469745 --additional-package nixosTests.cosmic-autologin-noxwayland --additional-package nixosTests.cosmic-autologin --additional-package nixosTests.cosmic --additional-package nixosTests.cosmic-noxwayland
Commit: 2cf6dc1252dad16ffa703148a8e3e63a28bb78ce
aarch64-linux
✅ 4 tests built:
- nixosTests.cosmic
- nixosTests.cosmic-autologin
- nixosTests.cosmic-autologin-noxwayland
- nixosTests.cosmic-noxwayland
✅ 45 packages built:
- cosmic-applets
- cosmic-applibrary
- cosmic-bg
- cosmic-comp
- cosmic-comp.debug
- cosmic-design-demo
- cosmic-edit
- cosmic-ext-applet-caffeine
- cosmic-ext-applet-external-monitor-brightness
- cosmic-ext-applet-minimon
- cosmic-ext-applet-privacy-indicator
- cosmic-ext-applet-sysinfo
- cosmic-ext-applet-weather
- cosmic-ext-calculator
- cosmic-ext-tweaks
- cosmic-files
- cosmic-greeter
- cosmic-icons
- cosmic-idle
- cosmic-initial-setup
- cosmic-launcher
- cosmic-notifications
- cosmic-osd
- cosmic-panel
- cosmic-player
- cosmic-randr
- cosmic-reader
- cosmic-screenshot
- cosmic-session
- cosmic-settings
- cosmic-settings-daemon
- cosmic-store
- cosmic-term
- cosmic-wallpapers
- cosmic-workspaces-epoch
- cosmic-workspaces-epoch.debug
- examine
- forecast
- libcosmicAppHook
- nixpkgs-manual
- oboete
- quick-webapps
- tasks
- xdg-desktop-portal-cosmic
- xdg-desktop-portal-cosmic.debug
x86_64-linux
✅ 4 tests built:
- nixosTests.cosmic
- nixosTests.cosmic-autologin
- nixosTests.cosmic-autologin-noxwayland
- nixosTests.cosmic-noxwayland
✅ 45 packages built:
- cosmic-applets
- cosmic-applibrary
- cosmic-bg
- cosmic-comp
- cosmic-comp.debug
- cosmic-design-demo
- cosmic-edit
- cosmic-ext-applet-caffeine
- cosmic-ext-applet-external-monitor-brightness
- cosmic-ext-applet-minimon
- cosmic-ext-applet-privacy-indicator
- cosmic-ext-applet-sysinfo
- cosmic-ext-applet-weather
- cosmic-ext-calculator
- cosmic-ext-tweaks
- cosmic-files
- cosmic-greeter
- cosmic-icons
- cosmic-idle
- cosmic-initial-setup
- cosmic-launcher
- cosmic-notifications
- cosmic-osd
- cosmic-panel
- cosmic-player
- cosmic-randr
- cosmic-reader
- cosmic-screenshot
- cosmic-session
- cosmic-settings
- cosmic-settings-daemon
- cosmic-store
- cosmic-term
- cosmic-wallpapers
- cosmic-workspaces-epoch
- cosmic-workspaces-epoch.debug
- examine
- forecast
- libcosmicAppHook
- nixpkgs-manual
- oboete
- quick-webapps
- tasks
- xdg-desktop-portal-cosmic
- xdg-desktop-portal-cosmic.debug
|
Is it possible to backport it to stable v 25.11 ? |
|
Yes, but not immediately. I'd love a timer of sorts that after 2 weeks of merging in unstable (~1.5 weeks after cached), stable gets a backport of all PRs with the COSMIC tag. |
GaetanLepage
left a comment
There was a problem hiding this comment.
Diff LGTM.
Well done everyone!
Flake lock file updates:
• Updated input 'flake-parts':
'github:hercules-ci/flake-parts/2cccadc7357c0ba201788ae99c4dfa90728ef5e0' (2025-11-21)
→ 'github:hercules-ci/flake-parts/a34fae9c08a15ad73f295041fec82323541400a9' (2025-12-15)
• Updated input 'home-manager':
'github:nix-community/home-manager/6bcb2395ab9ed05616052262da526cd7c5b4b123' (2025-12-05)
→ 'github:nix-community/home-manager/8315c1544f383b791a3115c9959d1f27920e8320' (2025-12-15)
• Updated input 'moe':
'github:tchfoo/moe/bbb0f2232e2be3ce461e0016082a882a0016a9c3' (2025-11-17)
→ 'github:tchfoo/moe/7732315201d8d4d31ddffe2aff27fdd5b0caab26' (2025-12-10)
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/418468ac9527e799809c900eda37cbff999199b6' (2025-12-02)
→ 'github:NixOS/nixpkgs/2fbfb1d73d239d2402a8fe03963e37aab15abe8b' (2025-12-11)
• Updated input 'nixpkgs-patch-nixos-librechat-init':
'NixOS/nixpkgs#462287'
→ 'NixOS/nixpkgs#462287'
• Updated input 'nixpkgs-patcher':
'github:gepbird/nixpkgs-patcher/cf110da81fa1e3362dd9b97bf722a48e12d5e1a9' (2025-11-26)
→ 'github:gepbird/nixpkgs-patcher/fd95467b7f4452b95a0eb610fc96af572149c7d9' (2025-12-11)
• Updated input 'nur':
'github:nix-community/NUR/769f30b452bdab0a4b2809f65ec8f46f34f48de1' (2025-12-05)
→ 'github:nix-community/NUR/54adda505f20377ee704a2cd4a60c12483c32795' (2025-12-15)
• Updated input 'ymstnt-dotfiles':
'github:ymstnt/dotfiles/f443bf06d11db033ca48cfb23d114b75a4508c2a' (2025-11-28)
→ 'github:ymstnt/dotfiles/9c2f73ab945b096e29d0cf71c57568dc1ca9d1d5' (2025-12-15)
• Added input 'ymstnt-dotfiles/nixpkgs-patch-cosmic-stable':
'NixOS/nixpkgs#469745'
|
Is it possible to backport now (3 weeks later) to start new year with a stable Cosmic in a stable NixOS? |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.11
git worktree add -d .worktree/backport-469745-to-release-25.11 origin/release-25.11
cd .worktree/backport-469745-to-release-25.11
git switch --create backport-469745-to-release-25.11
git cherry-pick -x 4fba1e1186851f251ec198ad858425573fbf44cc 5b9d8f72a592763cf8271e1b1983ed0097bb265a 71b770d1086a48661201676089ff2ae24113615d f1aa5fb03fb46ad48320321b50f5d84f05aec315 629922f2f68fd80420f5b177e7312e90748f44cb 4bf1a700a8892a17026e447030f4aa45a3308745 39b8e0fbf798112d91b4532b34792485bb58d7ef 2ea339379581e765a7829bd827614aa605e2f0bf ad7026170dbfb88d49b8aa3dd8271f3d982557dc 83ce29008a5bc5c36ebe4864068b6896c054b21b 42de3f83ae89e3318e7384729e015b1332609f5e ed107cf54699b82fa885a391ece742a89efda343 76a6ca068943f4f8be8640f55e8d6807668e4835 1c94bb8bca27175a37fc66ac7f853ecb6af42a63 64a1352f3f400745c9631347b965c3fb08b67f52 553e5afbef51fcd4ccc77393b68c7f69790f4cc1 33d14838af708f7668ae1ed8a9b8ca6b6ae787a0 992c9c97144fc47e084336fbbcfe394ec0b2d167 482a3e96326cde5abb6f6b9277fb7e822d072ffc ff276ff73a4ff397c5a6866b32837236bcd7bd9b 98def3324115cdd5415c965bd35519467bfe95a1 90b38b2e665d2105db69517fe646bfea10c67a15 5daafb5a39f77c1b13dfaedcec159da05ef7fccb 828e156f2fca6ed59c269fc8dd4ed119ec3737db d182875635d3cf9f6569f4bd535cdcbd512e1da1 e7ba731e7e80a6f3fd9f8b6aabb67a7579d31479 02aeb4aee2dadbb50678f7f9a36bd061ff53cc20 46bf220b691dcfee3e1f867040cd1f79471bd411 0be8cfc3ec84dd4c2ea19b2a30d5751bfcb2cab4 77e9385d26eff145458a0360ce0820a8e7534beb 9a13917ffce7e320d439c697292acd40c22f1502 a14e4af9acf62beee999cf96e4c3d109882f8fa0 7d0d8136ee1dc6aa5bab0a41c9177a8acc101106 fe9d2e1a80f31693c9f28ea6e076ea549bff0b1c ec8a58373cb19879e1715dbe5bf13bc61b939c96 64c171affce88932e92910686c3187d8e6793ee2 1844338789d5410a16924fed4d38823c5f341e63 db2eed53ca6933ccf85cc29b57e279b3ae907ede 8e4c87e33ad6c0ea0eb22617ab51f924dbcf8316 38cffaf3dead496fa11a3526bbdfc427fea5e77b 030a1a8ffadace8e38a8eb9a37e0368b25923c41 b75c5c026bd598f325275beca0abd07313375642 2f044f6f7724f46e008a568e5fa80d27ef690703 79551fccaf8015ebfb311604abbcb1f5c4726b7e 3a210ad170fea829c4201f6dc398def124f02c44 9b7385581803d93179ea0284e1f8d755e7da5c62 8b07f9d3bfd1711eaab68249e3d28e3655ffa188 5ace860389eb008af647a929bff64cab55b2517c 959ce0c53b6098666941cfb7c1e3546315380efe 2cf6dc1252dad16ffa703148a8e3e63a28bb78ce |
COSMIC First stable release!
Diff: pop-os/cosmic-epoch@epoch-1.0.0-beta.9...epoch-1.0.0
cc: @NixOS/cosmic
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.