vimPlugins.nvim-treesitter: master -> main update#470883
Merged
HeitorAugustoLN merged 1 commit intoNixOS:masterfrom Dec 30, 2025
Merged
vimPlugins.nvim-treesitter: master -> main update#470883HeitorAugustoLN merged 1 commit intoNixOS:masterfrom
HeitorAugustoLN merged 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
requested review from
GaetanLepage,
PerchunPak,
khaneliman and
mrcjkb
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
Contributor
I was working on a PR for this but got distracted watching my Packers season pretty much end... Just bump the package in this PR instead of making a timing thing. Otherwise I can push the update to your branch. |
Member
Author
|
Ok, I'll update it |
Contributor
|
Can you run the grammars update too |
HeitorAugustoLN
force-pushed
the
nvim-treesitter-install
branch
from
5ae4657 to
2a358b8
Compare
Contributor
|
It should also have a module skip for a meta module iirc |
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
HeitorAugustoLN
force-pushed
the
nvim-treesitter-install
branch
from
2a358b8 to
bad5aeb
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
Contributor
|
Not at my computer atm, can you check if the tests need updating. I remember a workaround implemented when we first started updating based on main. |
Member
Author
|
|
HeitorAugustoLN
force-pushed
the
nvim-treesitter-install
branch
from
bad5aeb to
c10be1b
Compare
Member
Author
|
Only the first test required a fix, everything else built just fine |
13 tasks
khaneliman
reviewed
Dec 15, 2025
HeitorAugustoLN
force-pushed
the
nvim-treesitter-install
branch
from
c10be1b to
fcb979f
Compare
Contributor
|
Contributor
|
Looks like https://github.com/nvim-treesitter/nvim-treesitter-refactor (doesn't pass build since it's incompatible) got archived and replaced with https://github.com/nvim-treesitter/nvim-treesitter-locals. We can just create an alias for refactor, for now. |
PerchunPak
reviewed
Dec 29, 2025
Member
PerchunPak
left a comment
PerchunPak
left a comment
There was a problem hiding this comment.
The parser and queries for Nix are still the same, I wouldn't consider it a blocker just because of performance issues that are unrelated to this update
Even if it is unrelated to updating nvim-treesitter itself, the issue happens only after moving to the main branch. So this is a blocker; the performance regression makes working with relatively big Nix files painful.
Member
Editing large Nix files like the generated vim plugins and Lua package sets has always been slow and painful for me - and I'm still using nvim-treesitter on nixpkgs-unstable. I don't think the majority of Nix users will be spending a lot of time in large files like the generated ones in nixpkgs. local file_size = vim.fn.getfsize(file_path)
if file_size < 100 * 1024 then
vim.treesitter.start()
endEdit: Even without any Nix queries installed, I get really bad performance on Edit2: Using neovim-unwrapped with just the nix parser and the queries on the rtp:
|
Member
Are you talking about syntax highlighting or LSP/auto-formatting/etc? The latter is expected to be slow
My colorscheme (catppuccin) doesn't even bother setting colors for non-treesitter highlighting :( (or sets it incorrectly) Anyway, thanks for the work on those queries! |
Member
|
Found the problematic query and opened a PR with a fix:
Tree-sitter related features in general.
I use catppuccin too. I just disable all syntax highlighting and tree-sitter related things in large files. |
HeitorAugustoLN
force-pushed
the
nvim-treesitter-install
branch
2 times, most recently
from
c21d6c5 to
45ce741
Compare
Member
Author
|
nvim-treesitter/nvim-treesitter#8378 fixed performance issues for me |
nixpkgs-ci
bot
added
10.rebuild-linux: 101-500
PerchunPak
reviewed
Dec 29, 2025
Member
PerchunPak
left a comment
PerchunPak
left a comment
There was a problem hiding this comment.
Issues for me have also been resolved, thanks @mrcjkb!
The only blocker for my approval is https://github.com/NixOS/nixpkgs/pull/470883/changes#r2644986136
HeitorAugustoLN
force-pushed
the
nvim-treesitter-install
branch
from
45ce741 to
71f1b82
Compare
PerchunPak
approved these changes
Dec 30, 2025
mrcjkb
approved these changes
Dec 30, 2025
|
Thanks all for your hard work on this plus upstream fixes! |
Contributor
|
Merged
13 tasks
Contributor
|
The release notes reference a |
Member
|
@kfiz @gigamonster256 we forgot to merge #472119 so most of the plugins that still depend on nvim-treesitter are broken 🫤 If you can, don't update yet if you don't want to migrate right now |
Closed
3 tasks
3 tasks
This was referenced Jan 6, 2026
3 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvim-treesitter now defaults to the main branch, which have many breaking changes, including not installing queries by default, so we need to install them, when specified.
I manually updated nvim-treesitter to test it, and it works fine besides the missing grammars, them being:
ecma,jsxandhtml_tags.Closes #415438
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.