Skip to content

python3Packages.eth-hash: fix build with structuredAttrs #471526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philiptaron merged 1 commit into from
Jan 5, 2026
Merged

python3Packages.eth-hash: fix build with structuredAttrs #471526

philiptaron merged 1 commit into from
Jan 5, 2026
+3 −1

Conversation

@SFrijters
Copy link
Member

@SFrijters SFrijters commented Dec 17, 2025 •
edited by philiptaron
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@SFrijters SFrijters mentioned this pull request Dec 17, 2025
Open
4 tasks
@nixpkgs-ci nixpkgs-ci bot requested a review from hellwolf December 17, 2025 01:50
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Dec 17, 2025
@LunNova
Copy link
Member

LunNova commented Dec 20, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 471526 --package python3Packages.eth-hash
Commit: faec7b8323e852a0038d865aa65a01f4f8bca766

x86_64-linux

✅ 2 packages built:
  • python3Packages.eth-hash
  • python3Packages.eth-hash.dist (python3Packages.eth-hash.dist.dist)

aarch64-darwin

✅ 2 packages built:
  • python3Packages.eth-hash
  • python3Packages.eth-hash.dist (python3Packages.eth-hash.dist.dist)

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 20, 2025
@philiptaron philiptaron added this pull request to the merge queue Jan 5, 2026
Merged via the queue into NixOS:staging with commit e09d753 Jan 5, 2026
36 of 38 checks passed
@SFrijters SFrijters deleted the eth-hash-structuredattrs-staging branch January 23, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philiptaron philiptaron philiptaron approved these changes

@LunNova LunNova LunNova approved these changes

@FlorianFranzen FlorianFranzen Awaiting requested review from FlorianFranzen

@hellwolf hellwolf Awaiting requested review from hellwolf

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SFrijters @LunNova @philiptaron