Skip to content

nixos/nixos-init: conflict with postBootCommands and powerUpCommands #474454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nikstur merged 1 commit into from
Jan 8, 2026
Merged

nixos/nixos-init: conflict with postBootCommands and powerUpCommands #474454

nikstur merged 1 commit into from
Jan 8, 2026

Conversation

@Majiir
Copy link
Contributor

@Majiir Majiir commented Dec 26, 2025 •
edited
Loading

Asserts that postBootCommands and powerUpCommands are not supported when system.nixos-init is enabled. Partially addresses #474445.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • armv7l-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 26, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jan 3, 2026
l0b0
l0b0 approved these changes Jan 4, 2026
View reviewed changes
Copy link
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 4, 2026
nikstur
nikstur requested changes Jan 6, 2026
View reviewed changes
Copy link
Contributor

@nikstur nikstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the nixos-init test. You need to forcibly set postBootCommands = ""; in the test. qemu-vm injects a postBootCommand into every test closure.

@Majiir Majiir force-pushed the nixos-init-assertions branch from d60e88f to e656d18 Compare January 7, 2026 02:05
@Majiir
Copy link
Contributor Author

Majiir commented Jan 7, 2026

Oops, fixed.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 8, 2026
@nikstur nikstur added this pull request to the merge queue Jan 8, 2026
Merged via the queue into NixOS:master with commit 7f49ae6 Jan 8, 2026
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikstur nikstur nikstur approved these changes

+1 more reviewer

@l0b0 l0b0 l0b0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Majiir @l0b0 @nikstur