curl-impersonate: 1.2.0 -> 1.4.2#477365
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Feb 4, 2026
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 101-500
Member
Author
|
Rebased on nixos-unstable and run
|
nixpkgs-ci
bot
added
the
8.has: package (update)
Contributor
|
Does this still make sense to target staging? Probably easier to review it if its on master. I'd be happy to try to review it if you want to update it (I'm not a committer, though.) |
Member
Author
|
The standard procedure for reviewing PRs, that target staging, is to cherry-pick its commits to master. There are too many rebuilds, it doesn't really make sense to target master # checkout pr (I prefer to use git-extras)
git pr 477365 upstream
# get commit hash
git log -1
# then just cherry-pick it on master
git reset --hard upstream/master
git cherry-pick commit-sha
# and you can review PR as usual
nix-build -A curl-impersonate |
Contributor
|
Really? I didn't think much depended on curl-impersonate. I see plenty of things get merged to master with this class of rebuilds. Nonetheless, obviously you know better than I do. |
Member
Author
|
Actually, previous updates targeted master, so I will change the branch. Also, there were quite a few new versions released since I created this PR, so give me a couple of hours to update this |
PerchunPak
force-pushed
the
curl-imp-upd
branch
from
23e9ac1 to
6c762fa
Compare
PerchunPak
changed the title
Member
Author
|
Oh, and you are right, 300 rebuilds is not that big of a number. The docs recommend targeting staging if there are 500 or more rebuilds https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#changes-causing-mass-rebuilds And don't think you are an impostor. I also don't have the committer bit, and your amount of contributions is not that different from mine (yours 62 merged 101 reviewed mine 100 merged 415 reviews; I often review low-effort PRs, so that number is a bit inflated). Although I may get that permission soon |
Contributor
|
I didn't mean to seem too dramatic there, I was only suggesting that you probably did know better for curl-impersonate since I really don't know much about curl-impersonate (or at least the nixpkgs packaging for it). With that having said, I'll take a look at this shortly, thanks for updating! Good luck with your commit bit, I don't know much about that process but it's clear NixOS needs more committers to deal with the absurd load these days. |
Member
Author
I also don't have any experience with this library :)
Thanks! |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Member
Author
|
jchv
approved these changes
Feb 3, 2026
Contributor
jchv
left a comment
jchv
left a comment
There was a problem hiding this comment.
OK. I've ran the nixos tests, tested the curl-impersonate binaries manually, and did some basic tests on some of the other "dependencies" too. I think some of the dependencies may accidentally be depending on curl-impersonate and don't actually use or need any of the impersonate fork features, but rather just want libcurl and are using the unassuming curl cffi library (which is, in fact, bindings for curl-impersonate...) I kind of want to go knocking on some of the upstreams to make sure this is really what they intended, but it's not really a huge deal. curl-impersonate itself seems to still work, which I've validated by testing to make sure the ja3 hashes are as expected. The --impersonate flag on yt-dlp is still working. I can't think of anything else to test. LGTM!
nixpkgs-ci
bot
added
the
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2769 |
|
not work in darwin |
13 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelogs: https://github.com/lexiforest/curl-impersonate/releases
Diff: lexiforest/curl-impersonate@v1.2.0...v1.4.2
Notable changes:
chrome142andfirefox144Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.