Skip to content

vimPlugins.nvim-treesitter-legacy: use parsers from main branch#477675

Merged
khaneliman merged 1 commit intoNixOS:masterfrom
PerchunPak:nvim-treesitter-legacy-parsers
Feb 3, 2026
Merged

vimPlugins.nvim-treesitter-legacy: use parsers from main branch#477675
khaneliman merged 1 commit intoNixOS:masterfrom
PerchunPak:nvim-treesitter-legacy-parsers

Conversation

@PerchunPak
Copy link
Member

As @mrcjkb requested in #472119 (comment)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Comment on lines +8 to +12
let
from-main = self.nvim-treesitter.withPlugins f;
in
self.nvim-treesitter-legacy.overrideAttrs {
passthru.dependencies = map grammarToPlugin (f (tree-sitter.builtGrammars // builtGrammars));
passthru = { inherit (from-main) dependencies; };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the only way I can think of, to get grammars and queries, without duplicating code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a need for nvim-treesitter-legacy-parsers if it is an alias for nvim-treesitter-parsers

Also, #472119 has not yet landed in nixos-unstable, so no one should rely on it yet

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: vim Advanced text editor labels Jan 7, 2026
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use the legacy plugin, but change makes sense if we can reuse them fine with the legacy branch.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 3, 2026
@khaneliman khaneliman added this pull request to the merge queue Feb 3, 2026
Merged via the queue into NixOS:master with commit ae4b12b Feb 3, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vim Advanced text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants