Merged
Conversation
a07df4e to
e99cc9d
Compare
Contributor
Author
Squeezed this in just now.
So will skip that part of the tests on BE. |
e99cc9d to
a779a3a
Compare
Ralith
approved these changes
Jan 14, 2026
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KhronosGroup/glslang#4140
KhronosGroup/glslang#3799 says that this fails on non-LE platforms, but the problematic tool in question was moved to SPIRV-tools in KhronosGroup/glslang@3a7f787, so that might no longer be an issue…Making a note to check this out the next time my ppc64 machine is free, and send a follow-up PR to disable them on
!stdenv.hostPlatform.isLittleEndianif they still fail.Fails on non-LE due to different issues, skipping affected part of the tests.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.