Skip to content

glslang: Enable tests#479398

Merged
OPNA2608 merged 1 commit intoNixOS:stagingfrom
OPNA2608:add/glslang-tests
Jan 18, 2026
Merged

glslang: Enable tests#479398
OPNA2608 merged 1 commit intoNixOS:stagingfrom
OPNA2608:add/glslang-tests

Conversation

@OPNA2608
Copy link
Copy Markdown
Contributor

@OPNA2608 OPNA2608 commented Jan 12, 2026

KhronosGroup/glslang#4140

KhronosGroup/glslang#3799 says that this fails on non-LE platforms, but the problematic tool in question was moved to SPIRV-tools in KhronosGroup/glslang@3a7f787, so that might no longer be an issue…
Making a note to check this out the next time my ppc64 machine is free, and send a follow-up PR to disable them on !stdenv.hostPlatform.isLittleEndian if they still fail.

Fails on non-LE due to different issues, skipping affected part of the tests.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • powerpc64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Jan 12, 2026
@nixpkgs-ci nixpkgs-ci bot requested a review from Ralith January 12, 2026 16:04
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. labels Jan 12, 2026
@OPNA2608
Copy link
Copy Markdown
Contributor Author

Making a note to check this out the next time my ppc64 machine is free

Squeezed this in just now. gtest-based test suite has two failures on big-endian.

  1. UB in an error message, leading to different output:
    Glsl/CompileToAstTest.FromFile/array_frag fails on s390x because error-message depends on endianness KhronosGroup/glslang#2797
  2. Something that looks like an endian-related issue with some strings, and some things not parsing correctly:
    Glsl/GlslNonSemanticShaderDebugInfoSpirv13Test.FromFile/spv_debuginfo_coopmatKHR_comp fails on ppc64 KhronosGroup/glslang#4145

So will skip that part of the tests on BE.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 14, 2026
@OPNA2608 OPNA2608 mentioned this pull request Jan 16, 2026
13 tasks
@OPNA2608 OPNA2608 added this pull request to the merge queue Jan 18, 2026
Merged via the queue into NixOS:staging with commit 507c0a1 Jan 18, 2026
33 of 35 checks passed
@OPNA2608 OPNA2608 deleted the add/glslang-tests branch January 18, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants