Skip to content

shaderc: fix pc file generation #480475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
K900 merged 2 commits into from
Jan 15, 2026
Merged

shaderc: fix pc file generation #480475

K900 merged 2 commits into from
Jan 15, 2026

Conversation

@marcin-serwin
Copy link
Contributor

@marcin-serwin marcin-serwin commented Jan 15, 2026 •
edited
Loading

I should have written the proper patch the first time, sorry for that.

Fixes #477464 (comment)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 15, 2026
emilazy
emilazy reviewed Jan 15, 2026
View reviewed changes
@marcin-serwin marcin-serwin force-pushed the push-sumswuklyzum branch 2 times, most recently from db059e6 to bfa3788 Compare January 15, 2026 21:17
@K900
Copy link
Contributor

K900 commented Jan 15, 2026

Can we send this to staging-not-next? AFAICT ffmpeg is the only failure on next, and it's a lot of rebuilds.

@marcin-serwin marcin-serwin marked this pull request as draft January 15, 2026 22:00
@marcin-serwin marcin-serwin changed the base branch from staging-next to staging January 15, 2026 22:00
@marcin-serwin marcin-serwin marked this pull request as ready for review January 15, 2026 22:00
@nixpkgs-ci nixpkgs-ci bot closed this Jan 15, 2026
@nixpkgs-ci nixpkgs-ci bot reopened this Jan 15, 2026
@marcin-serwin
Copy link
Contributor Author

marcin-serwin commented Jan 15, 2026 •
edited
Loading

The broken pc files should be generally harmless, it seems like ffmpeg just does its own postprocessing on the pkg-config output which causes the incorrect interpretation. I think this can wait on staging.

@K900 K900 added this pull request to the merge queue Jan 15, 2026
Merged via the queue into NixOS:staging with commit 6d321be Jan 15, 2026
34 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilazy emilazy emilazy left review comments

@K900 K900 Awaiting requested review from K900

@philiptaron philiptaron Awaiting requested review from philiptaron

@Atemu Atemu Awaiting requested review from Atemu

@jopejoe1 jopejoe1 Awaiting requested review from jopejoe1

@justinas justinas Awaiting requested review from justinas

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcin-serwin @K900 @emilazy