python3Packages.angr: 9.2.193 -> 9.2.197#487341
python3Packages.angr: 9.2.193 -> 9.2.197#487341Feyorsh wants to merge 9 commits intoNixOS:stagingfrom
Conversation
fabaff
left a comment
There was a problem hiding this comment.
Thanks for your effort.
Please add yourself as maintainer.
| blink, | ||
| pythonOlder, | ||
| }: | ||
| let |
There was a problem hiding this comment.
Any change that xdia could be splitted out? I guess would updating the future easier.
There was a problem hiding this comment.
Potentially, although there are no dependents or users of xdia currently besides pyxdia. I would like to build it in a separate derivation, but that requires getting icu to build for Mingw. Maybe a change outside the scope of this update.
|
I am still trying to get Also, do you know of a way to avoid using the python package in the current directory (for pytest) instead of changing directories? |
|
@fabaff I tried compiling xdialdr with musl when not on x86_64-linux, but that also doesn't work (it's a known issue upstream that hasn't been fixed yet). That having been said I still think this is ready to merge. Do you have any additional comments or feedback that you'd like me to address? |
|
@fabaff friendly bump. Can this be merged? |
|
Just realized that there is already efforts to update the |
Includes changes from and supersedes #482447 (separate PR for 9.2.197 so we can drop unicorn-angr).
There are a few things that still need to be addressed:
Nevertheless it builds and on preliminary inspection it works ok, so I think this is ready for a first pass review.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.