Skip to content

python3Packages.angr: 9.2.193 -> 9.2.197#487341

Open
Feyorsh wants to merge 9 commits intoNixOS:stagingfrom
Feyorsh:angr
Open

python3Packages.angr: 9.2.193 -> 9.2.197#487341
Feyorsh wants to merge 9 commits intoNixOS:stagingfrom
Feyorsh:angr

Conversation

@Feyorsh
Copy link
Contributor

@Feyorsh Feyorsh commented Feb 5, 2026

Includes changes from and supersedes #482447 (separate PR for 9.2.197 so we can drop unicorn-angr).

There are a few things that still need to be addressed:

  • pyxdia: Does not run on aarch64-darwin (using blink) due to incompatible page sizes (likely an issue with 16K page sizes on Apple Silicon). Also not thrilled about downloading xdia.exe instead of building it, but that would require getting icu to build with pkgsCross.mingwW64
  • Some tests in angr test suite are OOM killed but the same ones don't consistently trigger this behavior
  • I ran into issues running the tests in the cwd due to Python finding the "raw" version of angr as opposed to the version we just compiled. Changing directories fixes this issue, but I'm sure there has to be a better way

Nevertheless it builds and on preliminary inspection it works ok, so I think this is ready for a first pass review.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

github-actions[bot]

This comment was marked as outdated.

@Feyorsh Feyorsh changed the base branch from master to staging February 5, 2026 16:56
@nixpkgs-ci nixpkgs-ci bot closed this Feb 5, 2026
@nixpkgs-ci nixpkgs-ci bot reopened this Feb 5, 2026
@nixpkgs-ci nixpkgs-ci bot requested review from fabaff and natsukium February 5, 2026 17:09
@nixpkgs-ci nixpkgs-ci bot added 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Feb 5, 2026
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort.

Please add yourself as maintainer.

blink,
pythonOlder,
}:
let
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any change that xdia could be splitted out? I guess would updating the future easier.

Copy link
Contributor Author

@Feyorsh Feyorsh Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially, although there are no dependents or users of xdia currently besides pyxdia. I would like to build it in a separate derivation, but that requires getting icu to build for Mingw. Maybe a change outside the scope of this update.

@Feyorsh
Copy link
Contributor Author

Feyorsh commented Feb 6, 2026

I am still trying to get pyxdia working on aarch64-darwin, but I'm marking it as broken for the time being. There is no loss in functionality for cle/angr as we weren't building it at all before.

Also, do you know of a way to avoid using the python package in the current directory (for pytest) instead of changing directories?

@Feyorsh Feyorsh changed the title python3Packages.angr: 9.2.154 -> 9.2.197 python3Packages.angr: 9.2.193 -> 9.2.197 Feb 6, 2026
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 7, 2026
@Feyorsh
Copy link
Contributor Author

Feyorsh commented Feb 11, 2026

@fabaff I tried compiling xdialdr with musl when not on x86_64-linux, but that also doesn't work (it's a known issue upstream that hasn't been fixed yet).

That having been said I still think this is ready to merge. Do you have any additional comments or feedback that you'd like me to address?

@Feyorsh Feyorsh requested a review from fabaff February 11, 2026 02:33
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 11, 2026
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 18, 2026
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 19, 2026
@Feyorsh
Copy link
Contributor Author

Feyorsh commented Feb 23, 2026

@fabaff friendly bump. Can this be merged?

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 27, 2026
@misaka18931
Copy link

Just realized that there is already efforts to update the angr package!
I have also tried to update angr and its related packages to 9.2.204,
with full test coverage and docs & man page output.
Unfortunately though I currently only have access to x86_64-linux
machines. Otherwise I would love to help with the pyxdia package.
I was thinking of opening a PR tomorrow, now since we already have this,
may be I should rebase onto this PR?

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Mar 7, 2026
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 7, 2026
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. labels Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants