Open
Conversation
nixpkgs-ci
bot
requested review from
Scrumplex,
getchoo,
pluiedev and
vgskye
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Member
Author
|
nixpkgs-ci
bot
added
the
12.approvals: 1
Scrumplex
reviewed
Feb 13, 2026
Eveeifyeve
force-pushed
the
vesktop-darwin-fix
branch
from
09a3b7c to
974632b
Compare
Fixes NixOS#484618 Co-authored-by: Luke Davis <op_@outlook.com>
Eveeifyeve
force-pushed
the
vesktop-darwin-fix
branch
from
974632b to
10b2e95
Compare
Member
|
Scrumplex
approved these changes
Feb 15, 2026
nixpkgs-ci
bot
added
12.approvals: 2
tomrfitz
added a commit
to tomrfitz/nix-config
that referenced
this pull request
Feb 15, 2026
Upstream electron-builder no longer respects CSC_IDENTITY_AUTO_DISCOVERY; pass -c.mac.identity=null directly instead. Mirrors NixOS/nixpkgs#489725. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tomrfitz
added a commit
to tomrfitz/nix-config
that referenced
this pull request
Feb 15, 2026
Upstream electron-builder no longer respects CSC_IDENTITY_AUTO_DISCOVERY; pass -c.mac.identity=null directly instead. Mirrors NixOS/nixpkgs#489725. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
bengsparks
approved these changes
Feb 21, 2026
| @@ -119,7 +113,8 @@ stdenv.mkDerivation (finalAttrs: { | |||
| --dir \ | |||
| -c.asarUnpack="**/*.node" \ | |||
| -c.electronDist=${if stdenv.hostPlatform.isDarwin then "." else "electron-dist"} \ | |||
| -c.electronVersion=${electron.version} | |||
| -c.electronVersion=${electron.version} \ | |||
| ${lib.optionalString stdenv.hostPlatform.isDarwin "-c.mac.identity=null"} # disable code signing on macos, https://github.com/electron-userland/electron-builder/blob/77f977435c99247d5db395895618b150f5006e8f/docs/code-signing.md#how-to-disable-code-signing-during-the-build-process-on-macos | |||
Contributor
There was a problem hiding this comment.
This comment should likely be moved out of the embedded string.
Otherwise LGTM.
nixpkgs-ci
bot
added
12.approvals: 3+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #484618
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.