switch-to-configuration-ng: remove nested src directories#490861
Merged
jmbaur merged 1 commit intoNixOS:staging-nixosfrom Feb 22, 2026
Merged
switch-to-configuration-ng: remove nested src directories#490861jmbaur merged 1 commit intoNixOS:staging-nixosfrom
jmbaur merged 1 commit intoNixOS:staging-nixosfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
nixpkgs-ci
bot
added
the
2.status: merge conflict
ElvishJerricco
approved these changes
Feb 21, 2026
Contributor
ElvishJerricco
left a comment
ElvishJerricco
left a comment
There was a problem hiding this comment.
Huh, I thought filterSource had the same problem with chroot stores / the installer tests that filesets had; but given that the commit introducing the use of filterSource was written to fix the problem with the installer tests, I guess that's wrong and filterSource is actually fine: f665268
Contributor
|
Oh, this needs to target |
nixpkgs-ci
bot
added
the
12.approvals: 1
This was originally introduced when we ran into lib.fileset issues, but we can use builtins.filterSource instead, like `nixos-firewall-tool` does.
jmbaur
force-pushed
the
jared/stc-remove-nested-src
branch
from
5d6a3bc to
db6ca70
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
ah thanks, good catch |
github-actions
bot
dismissed
their stale review
Review dismissed automatically
nixpkgs-ci
bot
removed
the
2.status: merge conflict
Merged
via the queue into
NixOS:staging-nixos
with commit Feb 22, 2026
717b68d
37 of 46 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally introduced when we ran into lib.fileset issues, but we can use builtins.filterSource instead, like
nixos-firewall-tooldoes.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.