Skip to content

haskellPackages.hip: increase simplifier ticks#492093

Merged
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
Ai-Ya-Ya:fix-hip
Feb 24, 2026
Merged

haskellPackages.hip: increase simplifier ticks#492093
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
Ai-Ya-Ya:fix-hip

Conversation

@Ai-Ya-Ya
Copy link
Copy Markdown

@Ai-Ya-Ya Ai-Ya-Ya commented Feb 19, 2026 •
edited
Loading

GHC 9.10 made it so that the build fails with the default GHC setting of -fsmipl-tick-factor=100. Increasing it to 200 fixes this. Compilation time is not significantly longer than before, suggesting this change is mostly innocent.

Relevant issue and PR

Things done

  • Built on platform:
    • x86_64-linux (wsl)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable: (no semantic changes to library, not applicable)
  • Ran (running) nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

github-actions[bot]

This comment was marked as outdated.

Sign in to view

@Ai-Ya-Ya Ai-Ya-Ya changed the base branch from master to haskell-updates February 19, 2026 13:20
@nixpkgs-ci nixpkgs-ci bot closed this Feb 19, 2026
@nixpkgs-ci nixpkgs-ci bot reopened this Feb 19, 2026
@github-actions github-actions bot dismissed their stale review February 19, 2026 13:20

Review dismissed automatically

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 12.first-time contribution This PR is the author's first one; please be gentle! 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Feb 19, 2026
@Ai-Ya-Ya Ai-Ya-Ya marked this pull request as draft February 19, 2026 13:34
@Ai-Ya-Ya
Copy link
Copy Markdown
Author

Ai-Ya-Ya commented Feb 19, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 492093
Commit: cd7377f5a04b3cbb5d3b15735ee03fbfc4e74b04

x86_64-linux

❌ 3 packages failed to build:
  • haskellPackages.perceptual-hash
  • haskellPackages.perceptual-hash.data
  • haskellPackages.perceptual-hash.doc
✅ 3 packages built:
  • haskell.package-list
  • haskellPackages.hip
  • haskellPackages.hip.doc

@Ai-Ya-Ya Ai-Ya-Ya marked this pull request as ready for review February 19, 2026 15:17
@Ai-Ya-Ya
Copy link
Copy Markdown
Author

Ai-Ya-Ya commented Feb 19, 2026 •
edited
Loading

perceptual-hash is broken because of avif, which is broken because of #478368 . Irrelevant to this PR.

@Ai-Ya-Ya
haskellPackages.hip: increase simplifier ticks
9dd7204 
build fails on GHC 9.10 due to simplifier ticks exhausted
(lehins/hip#56), simply increase tick
threshold

relevant PR: lehins/hip#57
@Ai-Ya-Ya
Copy link
Copy Markdown
Author

Ai-Ya-Ya commented Feb 24, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 492093
Commit: 9dd7204f9fe12be20714f940fda2769c55360d70

x86_64-linux

❌ 3 packages failed to build:
  • haskellPackages.perceptual-hash
  • haskellPackages.perceptual-hash.data
  • haskellPackages.perceptual-hash.doc
✅ 3 packages built:
  • haskell.package-list
  • haskellPackages.hip
  • haskellPackages.hip.doc

@wolfgangwalther wolfgangwalther added this pull request to the merge queue Feb 24, 2026
Merged via the queue into NixOS:haskell-updates with commit 568d777 Feb 24, 2026
28 of 30 checks passed
@Ai-Ya-Ya Ai-Ya-Ya deleted the fix-hip branch February 24, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@maralorn maralorn Awaiting requested review from maralorn

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ai-Ya-Ya @wolfgangwalther