Skip to content

Comments

[staging-next] python3Packages.flask-limiter: fix build#492828

Merged
mdaniels5757 merged 1 commit intoNixOS:staging-nextfrom
mdaniels5757:fix-flask-limiter-build
Feb 21, 2026
Merged

[staging-next] python3Packages.flask-limiter: fix build#492828
mdaniels5757 merged 1 commit intoNixOS:staging-nextfrom
mdaniels5757:fix-flask-limiter-build

Conversation

@mdaniels5757
Copy link
Member

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: python Python is a high-level, general-purpose programming language. labels Feb 21, 2026
@mdaniels5757 mdaniels5757 force-pushed the fix-flask-limiter-build branch from 2f51493 to 93ecb45 Compare February 21, 2026 18:05
Copy link
Member

@thunze thunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Builds on Python 3.13 and 3.14

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Feb 21, 2026
@mdaniels5757
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 492828
Commit: 93ecb454fb4588dd4fecf569600654c0c433e49c


x86_64-linux

❌ 6 packages failed to build:
  • calibre-web
  • calibre-web.dist
  • fittrackee
  • fittrackee.dist
  • libretranslate (python313Packages.libretranslate)
  • libretranslate.dist (python313Packages.libretranslate.dist)
✅ 6 packages built:
  • octoprint
  • octoprint.dist
  • python313Packages.flask-limiter
  • python313Packages.flask-limiter.dist
  • python314Packages.flask-limiter
  • python314Packages.flask-limiter.dist

aarch64-linux

❌ 6 packages failed to build:
  • calibre-web
  • calibre-web.dist
  • fittrackee
  • fittrackee.dist
  • libretranslate (python313Packages.libretranslate)
  • libretranslate.dist (python313Packages.libretranslate.dist)
✅ 6 packages built:
  • octoprint
  • octoprint.dist
  • python313Packages.flask-limiter
  • python313Packages.flask-limiter.dist
  • python314Packages.flask-limiter
  • python314Packages.flask-limiter.dist

aarch64-darwin

❌ 6 packages failed to build:
  • calibre-web
  • calibre-web.dist
  • libretranslate (python313Packages.libretranslate)
  • libretranslate.dist (python313Packages.libretranslate.dist)
  • octoprint
  • octoprint.dist
✅ 4 packages built:
  • python313Packages.flask-limiter
  • python313Packages.flask-limiter.dist
  • python314Packages.flask-limiter
  • python314Packages.flask-limiter.dist

Error logs: `x86_64-linux`
calibre-web
  File "<string>", line 1, in <module>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                  ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 1, in <lambda>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                                       ~~~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/nix/store/m1fw8l8y9ycxh5dzispbb7cwl6rra14l-python3-3.13.12/lib/python3.13/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 1023, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/nix/store/syaj0di3n6m8wkzbw52rk9i5gh5a3s3j-calibre-web-0.6.25/lib/python3.13/site-packages/calibreweb/__init__.py", line 28, in <module>
    from cps.main import main
  File "/nix/store/syaj0di3n6m8wkzbw52rk9i5gh5a3s3j-calibre-web-0.6.25/lib/python3.13/site-packages/calibreweb/cps/__init__.py", line 113, in <module>
    limiter = Limiter(key_func=True, headers_enabled=True, auto_check=False, swallow_errors=False)
TypeError: Limiter.__init__() got an unexpected keyword argument 'auto_check'

Error logs: `aarch64-linux`
calibre-web
  File "<string>", line 1, in <module>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                  ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 1, in <lambda>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                                       ~~~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/nix/store/jbxc3f1gbnnx5wwhby9z56w95k44n0sw-python3-3.13.12/lib/python3.13/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 1023, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/nix/store/y2lczkhx0f7plgbr4g2yajibs02nhsli-calibre-web-0.6.25/lib/python3.13/site-packages/calibreweb/__init__.py", line 28, in <module>
    from cps.main import main
  File "/nix/store/y2lczkhx0f7plgbr4g2yajibs02nhsli-calibre-web-0.6.25/lib/python3.13/site-packages/calibreweb/cps/__init__.py", line 113, in <module>
    limiter = Limiter(key_func=True, headers_enabled=True, auto_check=False, swallow_errors=False)
TypeError: Limiter.__init__() got an unexpected keyword argument 'auto_check'

Error logs: `aarch64-darwin`
calibre-web
  File "<string>", line 1, in <module>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                  ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 1, in <lambda>
    import sys; import importlib; list(map(lambda mod: importlib.import_module(mod), sys.argv[1:]))
                                                       ~~~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/nix/store/h2y0a3x6hgznqq54rjszbi2x0rdnlgvb-python3-3.13.12/lib/python3.13/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 1023, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/nix/store/wnp4d5w50qgbx2f88fbz1cqf5xqcd7bp-calibre-web-0.6.25/lib/python3.13/site-packages/calibreweb/__init__.py", line 28, in <module>
    from cps.main import main
  File "/nix/store/wnp4d5w50qgbx2f88fbz1cqf5xqcd7bp-calibre-web-0.6.25/lib/python3.13/site-packages/calibreweb/cps/__init__.py", line 113, in <module>
    limiter = Limiter(key_func=True, headers_enabled=True, auto_check=False, swallow_errors=False)
TypeError: Limiter.__init__() got an unexpected keyword argument 'auto_check'
octoprint
    with octoprint.util.bom_aware_open(

tests/util/test_file_helpers.py::BomAwareOpenTest::test_bom_aware_open_with_bom
/nix/var/nix/builds/nix-32586-882534974/source/tests/util/test_file_helpers.py:31: DeprecationWarning: Please use open with '-sig' encoding instead
with octoprint.util.bom_aware_open(

tests/util/test_file_helpers.py::BomAwareOpenTest::test_bom_aware_open_without_bom
/nix/var/nix/builds/nix-32586-882534974/source/tests/util/test_file_helpers.py:44: DeprecationWarning: Please use open with '-sig' encoding instead
with octoprint.util.bom_aware_open(

tests/util/test_resettable_timer.py::ResettableTimerTest::test_canceled_callback
tests/util/test_resettable_timer.py::ResettableTimerTest::test_function
tests/util/test_resettable_timer.py::ResettableTimerTest::test_reset_callback
/nix/store/fmjrk0pbwqynxzbg1vgd3xqli634895h-python3.13-OctoPrint-1.11.6/lib/python3.13/site-packages/octoprint/util/init.py:1394: DeprecationWarning: isSet() is deprecated, use is_set() instead
if not self._event.isSet():

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/util/test_repeated_timer.py::RepeatedTimerTest::test_adjusted_interval - AssertionError: 15.989845991134644 not less than 7
===== 1 failed, 1012 passed, 2 deselected, 35 warnings in 62.29s (0:01:02) =====

@mdaniels5757 mdaniels5757 added this pull request to the merge queue Feb 21, 2026
Merged via the queue into NixOS:staging-next with commit b1c385f Feb 21, 2026
29 of 32 checks passed
@mdaniels5757 mdaniels5757 deleted the fix-flask-limiter-build branch February 21, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants