Closed
Conversation
nixpkgs-ci
bot
requested review from
Defelo,
amesgen,
dvn0,
faukah,
gador,
lorenzleutgeb,
matthiasbeyer and
philiptaron
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Defelo
requested changes
Mar 1, 2026
| lib.makeOverridable ( | ||
| { | ||
| seed, | ||
| seed ? "seed.radicle.xyz", |
Member
There was a problem hiding this comment.
We intentionally didn't specify a default value here, see #434360 (comment)
| { | ||
| seed, | ||
| seed ? "seed.radicle.xyz", | ||
| explorer ? "app.radicle.xyz", |
Member
There was a problem hiding this comment.
This is irrelevant for the fetcher
Comment on lines
+68
to
+69
| homepage = finalAttrs.src.homeUrl; | ||
| changelog = "${finalAttrs.src.homeUrl}/tree/NEWS.md"; |
Member
There was a problem hiding this comment.
IMO we should never refer to finalAttrs.src here because src is often overridden with something which doesn't have the attrs you are using or something which isn't an attrset at all (e.g. a path to a local dir), so in these cases evaluation would fail here.
Member
Author
|
Ok, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchFromRadicleusage across nixpkgsThings done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.