Skip to content

nextcloud: direct pre-signed download link #498820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ser wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nextcloud: direct pre-signed download link #498820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions nixos/modules/services/web-apps/nextcloud.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@ let
'use_ssl' => ${lib.boolToString s3.useSsl},
${lib.optionalString (s3.region != null) "'region' => '${s3.region}',"}
'use_path_style' => ${lib.boolToString s3.usePathStyle},
'use_presigned_url' => ${lib.boolToString s3.usePresignedUrl},
${lib.optionalString (s3.sseCKeyFile != null) "'sse_c_key' => nix_read_secret('s3_sse_c_key'),"}
],
]
Expand Down Expand Up @@ -765,6 +766,15 @@ in
`http://hostname.domain/bucket` instead.
'';
};
usePresignedUrl = lib.mkOption {
type = lib.types.bool;
default = false;
description = ''
Allow bypassing nextcloud instance and serve files
directly from the S3 server. Such a download is protected
with a presigned download link.
'';
};
sseCKeyFile = lib.mkOption {
type = lib.types.nullOr lib.types.path;
default = null;
Expand Down Expand Up @@ -1314,6 +1324,14 @@ in
Use `services.nextcloud.secrets.mail_smtppassword` instead and set it to a file containing the password.
'';
}
{
assertion =
lib.versionAtLeast cfg.package.version "33.0.0"
|| cfg.config.objectstore.s3.use_presigned_url == null;
message = ''
Presigned URLs are only available on Nextcloud >= 33.0.0.
'';
}
];
}

Expand Down
Loading