nix-required-mounts: correctly handle relative paths in symlink_targets()#500772
Closed
SomeoneSerge wants to merge 3 commits intoNixOS:masterfrom
Closed
nix-required-mounts: correctly handle relative paths in symlink_targets()#500772SomeoneSerge wants to merge 3 commits intoNixOS:masterfrom
SomeoneSerge wants to merge 3 commits intoNixOS:masterfrom
Conversation
As per NixOS#497824, symlink_parents() incorrectly handles relative symlinks and produces non-existent paths. Fix and add unit test
Equivalent/dual view but probably more consistent and intuitive
tfc
reviewed
Mar 17, 2026
| p = target | ||
| else: | ||
| p = parent | ||
| p = p.parent / target |
Contributor
There was a problem hiding this comment.
this will not work. i have a branch with tests and other fixes online. i suggest we discuss that in a meeting this week to get on the same page because i have found multiple issues with the app. https://github.com/tfc/nixpkgs/tree/unwhack-nrm but i am currently still working on that, so expect changes in the next minutes
SomeoneSerge
commented
Mar 17, 2026
| parsed_drv = parsed_drv[canon_drv_path] | ||
| required_features = get_required_system_features(parsed_drv) | ||
| required_features = list(filter(known_features.__contains__, required_features)) | ||
| required_features = list( |
Contributor
Author
There was a problem hiding this comment.
Uh, accidentally ran black, maybe let it be
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Contributor
Author
|
Closing in favour #500971 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cf. #497824 (comment)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.