Skip to content

noctalia-shell: 4.6.7 -> 4.7.1#501377

Open
OldUser101 wants to merge 1 commit intoNixOS:masterfrom
OldUser101:update-noctalia-shell
Open

noctalia-shell: 4.6.7 -> 4.7.1#501377
OldUser101 wants to merge 1 commit intoNixOS:masterfrom
OldUser101:update-noctalia-shell

Conversation

@OldUser101
Copy link
Contributor

@OldUser101 OldUser101 commented Mar 19, 2026

  • bump noctalia-shell from 4.6.7 to 4.7.1
  • remove runtime dependency on cava

resolves #501303

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot requested a review from spacedentist March 19, 2026 18:16
@nixpkgs-ci nixpkgs-ci bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 19, 2026
@drawbu
Copy link
Member

drawbu commented Mar 19, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 501377
Commit: 523fb878972a3b65a5aef5cfb17aebdf336af1ce (subsequent changes)
Merge: 78c2b3cfa434b9d92dbcbbe537de29d65921d530

Logs: https://github.com/drawbu/nixpkgs-review-gha/actions/runs/23311039971


x86_64-linux

✅ 1 package built:
  • noctalia-shell

aarch64-linux

✅ 1 package built:
  • noctalia-shell

Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Audio: Native Pipewire spectrum (no external Cava needed)

Are we depending on cava anywhere and if so can we drop it?

@OldUser101 OldUser101 force-pushed the update-noctalia-shell branch from 523fb87 to 1b22b11 Compare March 19, 2026 20:59
@OldUser101
Copy link
Contributor Author

Audio: Native Pipewire spectrum (no external Cava needed)

Are we depending on cava anywhere and if so can we drop it?

It's still referenced in some source files upstream, though it seems to work fine without it. I'll leave the option present, but disabled by default.

@OldUser101 OldUser101 requested a review from NickCao March 19, 2026 21:00
Atemo-C added a commit to Atemo-C/NixOS-configuration that referenced this pull request Mar 20, 2026
@NickCao
Copy link
Member

NickCao commented Mar 20, 2026

Audio: Native Pipewire spectrum (no external Cava needed)

Are we depending on cava anywhere and if so can we drop it?

It's still referenced in some source files upstream, though it seems to work fine without it. I'll leave the option present, but disabled by default.

These are just leftovers, someone should open an upstream PR removing them, we can safety drop cava.

nix/package.nix
6:    cava
24:  cava,

Scripts/bash/template-apply.sh
7:    echo "Usage: $0 {kitty|ghostty|foot|alacritty|wezterm|fuzzel|walker|pywalfox|cava|yazi|labwc|niri|hyprland|sway|scroll|mango|btop|zathura} [dark|light]" >&2
222:cava)
223:    CONFIG_FILE="$HOME/.config/cava/config"
250:        # Reload cava if it's running, but only if it's not using stdin config
251:        if pgrep -f cava >/dev/null; then
252:            # Check if Cava is running with -p /dev/stdin (standalone cava)
253:            if ! pgrep -af cava | grep -q -- "-p.*stdin"; then
254:                pkill -USR1 cava
258:        echo "Error: cava config file not found at $CONFIG_FILE" >&2

CREDITS.md
25:- **[Cava](https://github.com/karlstav/cava)** - Audio visualizer component

Commons/Migrations/Migration57.qml
7:    logger.i("Settings", "Migrating settings to v57 (cavaFrameRate -> spectrumFrameRate)");
9:    if (rawJson && rawJson.audio && rawJson.audio.cavaFrameRate !== undefined) {
10:      adapter.audio.spectrumFrameRate = rawJson.audio.cavaFrameRate;
11:      logger.i("Settings", "Migrated cavaFrameRate:", rawJson.audio.cavaFrameRate, "-> spectrumFrameRate");

Commons/Migrations/Migration40.qml
7:  readonly property var templateIds: ["gtk", "qt", "kcolorscheme", "alacritty", "kitty", "ghostty", "foot", "wezterm", "fuzzel", "discord", "pywalfox", "vicinae", "walker", "code", "spicetify", "telegram", "cava", "yazi", "emacs", "niri", "hyprland", "mango", "zed", "helix", "zenBrowser"]

Services/Theming/TemplateRegistry.qml
292:      "id": "cava",
295:      "input": "cava.ini",
298:          "path": "~/.config/cava/themes/noctalia"
301:      "postProcess": () => `${templateApplyScript} cava`

@OldUser101 OldUser101 force-pushed the update-noctalia-shell branch from 1b22b11 to cc0b98b Compare March 20, 2026 22:58
@OldUser101
Copy link
Contributor Author

Audio: Native Pipewire spectrum (no external Cava needed)

Are we depending on cava anywhere and if so can we drop it?

It's still referenced in some source files upstream, though it seems to work fine without it. I'll leave the option present, but disabled by default.

These are just leftovers, someone should open an upstream PR removing them, we can safety drop cava.

nix/package.nix
6:    cava
24:  cava,

Scripts/bash/template-apply.sh
7:    echo "Usage: $0 {kitty|ghostty|foot|alacritty|wezterm|fuzzel|walker|pywalfox|cava|yazi|labwc|niri|hyprland|sway|scroll|mango|btop|zathura} [dark|light]" >&2
222:cava)
223:    CONFIG_FILE="$HOME/.config/cava/config"
250:        # Reload cava if it's running, but only if it's not using stdin config
251:        if pgrep -f cava >/dev/null; then
252:            # Check if Cava is running with -p /dev/stdin (standalone cava)
253:            if ! pgrep -af cava | grep -q -- "-p.*stdin"; then
254:                pkill -USR1 cava
258:        echo "Error: cava config file not found at $CONFIG_FILE" >&2

CREDITS.md
25:- **[Cava](https://github.com/karlstav/cava)** - Audio visualizer component

Commons/Migrations/Migration57.qml
7:    logger.i("Settings", "Migrating settings to v57 (cavaFrameRate -> spectrumFrameRate)");
9:    if (rawJson && rawJson.audio && rawJson.audio.cavaFrameRate !== undefined) {
10:      adapter.audio.spectrumFrameRate = rawJson.audio.cavaFrameRate;
11:      logger.i("Settings", "Migrated cavaFrameRate:", rawJson.audio.cavaFrameRate, "-> spectrumFrameRate");

Commons/Migrations/Migration40.qml
7:  readonly property var templateIds: ["gtk", "qt", "kcolorscheme", "alacritty", "kitty", "ghostty", "foot", "wezterm", "fuzzel", "discord", "pywalfox", "vicinae", "walker", "code", "spicetify", "telegram", "cava", "yazi", "emacs", "niri", "hyprland", "mango", "zed", "helix", "zenBrowser"]

Services/Theming/TemplateRegistry.qml
292:      "id": "cava",
295:      "input": "cava.ini",
298:          "path": "~/.config/cava/themes/noctalia"
301:      "postProcess": () => `${templateApplyScript} cava`

Done.

@AlexNabokikh
Copy link
Contributor

It is probably a good idea to bump it to a 4.7.1 in the PR, as it resolves some critical bugs with direct scanouts.

Atemo-C added a commit to Atemo-C/NixOS-configuration that referenced this pull request Mar 23, 2026
- bump `noctalia-shell` from 4.6.7 to 4.7.1
- remove runtime dependency on `cava`

resolves NixOS#501303
@OldUser101 OldUser101 force-pushed the update-noctalia-shell branch from cc0b98b to faeba3b Compare March 23, 2026 10:38
@OldUser101 OldUser101 changed the title noctalia-shell: 4.6.7 -> 4.7.0 noctalia-shell: 4.6.7 -> 4.7.1 Mar 23, 2026
@VuiMuich
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 501377
Commit: faeba3b8f45e49c14146fe2cf08299559c88eb40


x86_64-linux

✅ 1 package built:
  • noctalia-shell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Request: noctalia-shell 4.6.7 → 4.7.0

6 participants