Conversation
|
NickCao
left a comment
There was a problem hiding this comment.
Audio: Native Pipewire spectrum (no external Cava needed)
Are we depending on cava anywhere and if so can we drop it?
523fb87 to
1b22b11
Compare
It's still referenced in some source files upstream, though it seems to work fine without it. I'll leave the option present, but disabled by default. |
Waiting for NixOS/nixpkgs#501377 to be merged.
These are just leftovers, someone should open an upstream PR removing them, we can safety drop cava. |
1b22b11 to
cc0b98b
Compare
Done. |
|
It is probably a good idea to bump it to a 4.7.1 in the PR, as it resolves some critical bugs with direct scanouts. |
- bump `noctalia-shell` from 4.6.7 to 4.7.1 - remove runtime dependency on `cava` resolves NixOS#501303
cc0b98b to
faeba3b
Compare
|
noctalia-shellfrom 4.6.7 to 4.7.1cavaresolves #501303
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.