itgmania: add new package scope for themes#501591
Open
ungeskriptet wants to merge 3 commits intoNixOS:masterfrom
Open
itgmania: add new package scope for themes#501591ungeskriptet wants to merge 3 commits intoNixOS:masterfrom
ungeskriptet wants to merge 3 commits intoNixOS:masterfrom
Conversation
ungeskriptet
force-pushed
the
itgmania-packages
branch
from
0c982ee to
9512e25
Compare
ungeskriptet
requested review from
Maxwell-lt and
ftsimas
and removed request for
Maxwell-lt
I play this game as well and would like to adopt maintainership. Signed-off-by: David Wronek <david.wronek@mainlining.org>
Signed-off-by: David Wronek <david.wronek@mainlining.org>
ungeskriptet
force-pushed
the
itgmania-packages
branch
from
9512e25 to
9e35dc1
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
ungeskriptet
changed the title
definitely add Digital-Dance |
ungeskriptet
force-pushed
the
itgmania-packages
branch
from
9e35dc1 to
17b23f4
Compare
Member
Author
Done, thanks for the suggestion :) |
ungeskriptet
force-pushed
the
itgmania-packages
branch
from
17b23f4 to
6f4b02b
Compare
Add a new package scope for ITGmania. Themes and other extensions can be added here to allow configuring ITGmania declaratively using the extraPackages argument. Signed-off-by: David Wronek <david.wronek@mainlining.org>
ungeskriptet
force-pushed
the
itgmania-packages
branch
from
6f4b02b to
9c2219b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits introduce a new package scope (
itgmaniaPackages), which can be used to group together themes and other extensions for the game. To achieve configuring ITGmania declaratively, we can override the extraPackages argument of the ITGmania package using a list of packages. I had to wrap ITGmania with symlinkJoin to avoid rebuilding the entire package.Can be tested using
@rehtlaw Are there any other themes or extensions I should package for ITGmania?
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.