Skip to content

djgpp_i586, djgpp_i686: migrate to by-name, migrate lowPrio override to by-name#501790

Open
guylamar2006 wants to merge 3 commits intoNixOS:masterfrom
guylamar2006:migrate-djgpp
Open

djgpp_i586, djgpp_i686: migrate to by-name, migrate lowPrio override to by-name#501790
guylamar2006 wants to merge 3 commits intoNixOS:masterfrom
guylamar2006:migrate-djgpp

Conversation

@guylamar2006
Copy link
Contributor

@guylamar2006 guylamar2006 commented Mar 20, 2026

This pull request restructures and updates the packaging for the DJGPP compiler in Nixpkgs. The main changes include moving and renaming the package for better organization, introducing a new i686 variant, and updating build flags to improve compatibility with older C code and specific dependencies.

Package restructuring and new variant:

  • Moved and renamed the DJGPP package from pkgs/development/compilers/djgpp/default.nix to pkgs/by-name/dj/djgpp_i586/package.nix for improved organization.
  • Added a new djgpp_i686 package variant, based on djgpp_i586, using the "i686" target architecture.

Build and compatibility improvements:

  • Switched from stdenv to gccStdenv to ensure the correct build environment and set stdenv = gccStdenv explicitly.
  • Disabled the strictflexarrays1 hardening flag (in addition to format) to prevent build failures with old C code.
  • Set CFLAGS = "-std=gnu17" to force the use of the C17 standard for compatibility with GMP 6.2.1's configure script.

Package set cleanup:

  • Updated pkgs/top-level/all-packages.nix to reference the new package locations and remove the old DJGPP package definitions.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@guylamar2006 guylamar2006 changed the title Migrate djgpp djgpp_i586, djgpp_i686: migrate to by-name, migrate lowPrio override to by-name Mar 20, 2026
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Mar 20, 2026
@guylamar2006
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 501790
Commit: d90d74118742658916c7146c52668d48b3de7849 (subsequent changes)
Merge: 049830b99b7ccb5d5e6d2c5e2d629106a8596f14

Logs: https://github.com/guylamar2006/nixpkgs-review-gha/actions/runs/23381119029


x86_64-linux

✅ 2 packages built:
  • djgpp (djgpp_i586)
  • djgpp_i686

aarch64-linux

✅ 2 packages built:
  • djgpp (djgpp_i586)
  • djgpp_i686

x86_64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • djgpp (djgpp_i586)
  • djgpp_i686

aarch64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • djgpp (djgpp_i586)
  • djgpp_i686

@guylamar2006 guylamar2006 marked this pull request as ready for review March 21, 2026 22:21
@nixpkgs-ci nixpkgs-ci bot requested a review from hughobrien March 21, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant