Skip to content

Conversation

@edolstra
Copy link
Member

@edolstra edolstra commented Nov 11, 2025

This already failed to evaluate due to pre-commit's dependency on dotnet-sdk, which is unsupported on i686-linux.

It also adds nix flake check --all-systems --no-build to CI to catch regressions like this.

This already failed to evaluate due to pre-commit's dependency on dotnet-sdk, which is unsupported on i686-linux.

This makes `nix flake check --all-systems` succeed again.
constituents = [
self.hydraJobs.tarball
self.hydraJobs.build.x86_64-linux
self.hydraJobs.build.i686-linux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we not rather exclude pre-commit for 32-bit? I think patchelf in nixpkgs ist still needed for 32-bit libs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgsi686Linux still has quiet a few references.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I initially tried, but flake-parts seems to pull in pre-commit as well in the dev shell. We could just remove devShells.i686-linux.default...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants