Conversation
Supports several basis functions for the trend and adds a handler for these functions
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Hi, thanks for your contribution, this is really cool! Two comments:
|
|
We need to add a deprecation warning for an argument of NBEATS to ensure backward compatibility
Marco had some doubts merging this already, so keeping it under review for now
|
I'm happy with this version of NBEATS now. Thank you @tblume1992 for your patience! We'll adjust according to the review comments! |
|
Hello, First of all great job and thanks for this improvement! |
By default NBEATs only utilizes a polynomial basis for the trend component. This PR adds support for several different basis functions for the trend and adds a handler for these functions in a new 'DynamicNBEATs' method.