Skip to content

[FIX] Recurrent predictions#1285

Merged
marcopeix merged 1 commit intomainfrom
fix/recurrent_predictions
Mar 12, 2025
Merged

[FIX] Recurrent predictions#1285
marcopeix merged 1 commit intomainfrom
fix/recurrent_predictions

Conversation

@elephaint
Copy link
Contributor

@elephaint elephaint commented Mar 9, 2025

When setting recurrent=True in recursive models (LSTM, GRU, RNN) there is a bug that ignores the latest available ground truth in the forecast (i.e., off-by-one error). This makes forecasts slightly worse, thus fixing the bug improves forecast quality when making forecasts with recursive=True.

@elephaint elephaint added the bug label Mar 9, 2025
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@elephaint elephaint requested a review from marcopeix March 9, 2025 15:38
Copy link
Contributor

@marcopeix marcopeix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@marcopeix marcopeix merged commit 4fdc4de into main Mar 12, 2025
17 checks passed
@marcopeix marcopeix deleted the fix/recurrent_predictions branch March 12, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants