FIX: Add exclude_insample_y param to TimeXer for model loading#1306
Merged
FIX: Add exclude_insample_y param to TimeXer for model loading#1306
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
elephaint
requested changes
Apr 1, 2025
Contributor
elephaint
left a comment
elephaint
left a comment
There was a problem hiding this comment.
I think we need to find a fix to nbdev not processing auto* files before upgrading the version.
elephaint
approved these changes
Apr 2, 2025
Contributor
elephaint
left a comment
elephaint
left a comment
There was a problem hiding this comment.
LGTM, subject to tests no longer failing
LeonEthan
added a commit
to LeonEthan/neuralforecast
that referenced
this pull request
Apr 3, 2025
FIX: Add exclude_insample_y param to TimeXer for model loading (Nixtla#1306)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TimeXer cannot be loaded because it didn't handle the
exclude_insample_yparameter correctly. I added it to theinitof the model and loading works now.