Fix type of n_windows in cross_validation#1378
Merged
marcopeix merged 2 commits intoNixtla:mainfrom Jan 12, 2026
Merged
Conversation
|
|
Contributor
|
Hi @Riklia, I want to make a release of neuralforecast soon and would like to include your PR. Can you solve the conflict please? Thanks! |
43688bc to
b82c40e
Compare
Contributor
Author
|
Hi @marcopeix! I rebased, and it should be fine now. |
marcopeix
requested changes
Jan 9, 2026
Contributor
marcopeix
left a comment
There was a problem hiding this comment.
Hello @Riklia , can you address these comments please? Also, make sure to install the pre-commit hooks with:
pre-commit install
pre-commit run --files neuralforecast/*
Linting errors should be picked up before you make a PR.
Thanks!
b82c40e to
a2ddb14
Compare
Add assertion checks to satisfy mypy and prevent invalid values from propagating into the validation logic.
a2ddb14 to
49b104b
Compare
Contributor
Author
|
Thanks for the detailed instructions! Addressed all the comments. |
marcopeix
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in the documentation and in the implementation, when test_size is defined, we set n_windows to None. However, the type of
n_windowsis specified as int. This causes a warning on the caller side.