Added readdirextra to expose raw file properties#13
Open
KanoYugoro wants to merge 2 commits intoNode-SMB:masterfrom
Open
Added readdirextra to expose raw file properties#13KanoYugoro wants to merge 2 commits intoNode-SMB:masterfrom
KanoYugoro wants to merge 2 commits intoNode-SMB:masterfrom
Conversation
Was not sure about the naming convention for this particular function, but I have a great need to read particular file properties on individual files without loading the entire file into memory. I added a new function so as not to break backwards compatibility of this package. I did not add any logic to parse these individual file properties, as I know things like times and dates are stored differently or mean different things between operating systems.
|
👍 |
|
👍 |
Author
|
@marsaud Is there any chance I could get this pulled in? |
Author
|
@marsaud Just checking in again. Any chance to look at this? I can fork and publish my own version of this if you can't be bothered to maintain it. |
Member
|
@marsaud can you take a look at this and evaluate the "risk" to merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was not sure about the naming convention for this particular function,
but I have a great need to read particular file properties on individual
files without loading the entire file into memory. I added a new
function so as not to break backwards compatibility of this package. I
did not add any logic to parse these individual file properties, as I
know things like times and dates are stored differently or mean
different things between operating systems.
If there is anything else you need me to do with this branch, or have
suggestions on how to better go about what I am trying to achieve,
please let me know. Thank you!