Skip to content

Commit f6cd8cc

Browse files
author
Ruben Bridgewater
committed
Warn in case of using the name option with hiredis set
1 parent 298d074 commit f6cd8cc

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

benchmark/index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,7 @@ var parserHiRedis = new Parser({
6565
var parser = new Parser({
6666
returnReply: checkReply,
6767
returnError: returnError,
68-
returnFatalError: returnError,
69-
name: 'javascript'
68+
returnFatalError: returnError
7069
})
7170

7271
// BULK STRINGS

benchmark/old/parser.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
'use strict'
22

33
var parsers = {
4-
Javascript: require('./javascript')
4+
javascript: require('./javascript')
55
}
66

77
// Hiredis might not be installed
88
try {
9-
parsers.Hiredis = require('./hiredis')
9+
parsers.hiredis = require('./hiredis')
1010
} catch (err) { /* ignore errors */ }
1111

1212
function Parser (options) {
@@ -45,9 +45,9 @@ function Parser (options) {
4545
}
4646

4747
if (options.name === 'javascript' || !parsers.hiredis || options.stringNumbers) {
48-
parser = new parsers.Javascript(innerOptions)
48+
parser = new parsers.javascript(innerOptions) // eslint-disable-line new-cap
4949
} else {
50-
parser = new parsers.Hiredis(innerOptions)
50+
parser = new parsers.hiredis(innerOptions) // eslint-disable-line new-cap
5151
}
5252

5353
parser.returnError = options.returnError

lib/parser.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ function JavascriptRedisParser (options) {
214214
if (options.name === 'hiredis') {
215215
try {
216216
var Hiredis = require('../test/hiredis')
217+
console.error(new TypeError('Using the hiredis parser is discouraged. Please remove the name option.').stack)
217218
return new Hiredis(options)
218219
} catch (e) {}
219220
}

0 commit comments

Comments
 (0)