Skip to content

Conversation

@Wodann
Copy link
Member

@Wodann Wodann commented Jan 8, 2026

Adds a reproduction case for the bug reported in NomicFoundation/hardhat#7834 and fixed by NomicFoundation/hardhat#7850

To Do

@Wodann Wodann self-assigned this Jan 8, 2026
@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Jan 8, 2026
@changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2026

⚠️ No Changeset found

Latest commit: 30636c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann temporarily deployed to github-action-benchmark January 8, 2026 18:32 — with GitHub Actions Inactive
@Wodann Wodann changed the title test: reproduce issue edr/1244 test: reproduce issue edr#1244 Jan 8, 2026
@Wodann Wodann requested a review from Copilot January 8, 2026 18:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a test case to reproduce issue edr#1244, which relates to block number handling after forking with hardhat_reset. The test verifies that when the network is reset with a specific fork block number, the current block number correctly reflects that forked block.

  • Adds reproduction test for block number verification after hardhat_reset with forking
  • Configures the test to use the Prague hardfork
  • Includes conditional skip logic for tests without ALCHEMY_URL configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

hardfork: "prague",
});

it("Issue edr/1244", async function () {
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test name 'Issue edr/1244' is not descriptive of what the test validates. Consider renaming to something like 'should return correct block number after hardhat_reset with forking' to clearly describe the expected behavior being tested.

Suggested change
it("Issue edr/1244", async function () {
it("should return correct block number after hardhat_reset with forking", async function () {

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.25%. Comparing base (8c1d0b4) to head (30636c5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1257   +/-   ##
=======================================
  Coverage   73.25%   73.25%           
=======================================
  Files         436      436           
  Lines       74168    74183   +15     
  Branches    74168    74183   +15     
=======================================
+ Hits        54330    54342   +12     
- Misses      17842    17845    +3     
  Partials     1996     1996           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Wodann Wodann temporarily deployed to github-action-benchmark January 8, 2026 19:18 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark January 8, 2026 19:18 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changeset needed This PR doesn't require a changeset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants