-
Notifications
You must be signed in to change notification settings - Fork 35
test: reproduce issue edr#1244 #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a test case to reproduce issue edr#1244, which relates to block number handling after forking with hardhat_reset. The test verifies that when the network is reset with a specific fork block number, the current block number correctly reflects that forked block.
- Adds reproduction test for block number verification after hardhat_reset with forking
- Configures the test to use the Prague hardfork
- Includes conditional skip logic for tests without ALCHEMY_URL configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| hardfork: "prague", | ||
| }); | ||
|
|
||
| it("Issue edr/1244", async function () { |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test name 'Issue edr/1244' is not descriptive of what the test validates. Consider renaming to something like 'should return correct block number after hardhat_reset with forking' to clearly describe the expected behavior being tested.
| it("Issue edr/1244", async function () { | |
| it("should return correct block number after hardhat_reset with forking", async function () { |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1257 +/- ##
=======================================
Coverage 73.25% 73.25%
=======================================
Files 436 436
Lines 74168 74183 +15
Branches 74168 74183 +15
=======================================
+ Hits 54330 54342 +12
- Misses 17842 17845 +3
Partials 1996 1996 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds a reproduction case for the bug reported in NomicFoundation/hardhat#7834 and fixed by NomicFoundation/hardhat#7850
To Do