Skip to content

Conversation

@Wodann
Copy link
Member

@Wodann Wodann commented Jan 30, 2026

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2026

⚠️ No Changeset found

Latest commit: d967786

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann changed the base branch from main to feat/geth-debugger January 30, 2026 21:00
claude and others added 14 commits January 30, 2026 21:29
…n to edr_solidity

This change consolidates trace construction logic by moving the conversion
function from CallTraceArena (revm-inspectors) to NestedTrace into the
edr_solidity crate, where NestedTrace is defined.

Changes:
- Add new module `edr_solidity::trace_arena_conversion` with the conversion function
- Add revm and revm-inspectors dependencies to edr_solidity
- Update Foundry's stack_trace.rs to use the conversion from edr_solidity
- Remove duplicate conversion code from Foundry

This enables both Foundry tests and the provider to use the same trace
construction implementation, ensuring consistency across the codebase.

The conversion function bridges the gap between the halt-reason-agnostic
TracingInspector and the halt-reason-aware NestedTrace format.
@Wodann Wodann force-pushed the refactor/tracing-unification branch from 8b2c0e0 to 4a2daf5 Compare January 30, 2026 21:37
@Wodann Wodann had a problem deploying to github-action-benchmark January 30, 2026 21:37 — with GitHub Actions Failure
@Wodann Wodann changed the title Refactor/tracing unification refactor: unify Solidity stack & call trace construction Jan 30, 2026
@Wodann Wodann had a problem deploying to github-action-benchmark January 30, 2026 22:08 — with GitHub Actions Failure
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 50.43747% with 963 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.80%. Comparing base (7d64ffc) to head (d967786).

Files with missing lines Patch % Lines
crates/edr_napi/src/trace/solidity_stack_trace.rs 0.00% 173 Missing ⚠️
crates/edr_napi_core/src/logger.rs 0.00% 164 Missing ⚠️
crates/edr_solidity/src/contract_decoder.rs 26.17% 108 Missing and 2 partials ⚠️
crates/edr_provider/src/error.rs 0.00% 52 Missing ⚠️
crates/edr_solidity/src/solidity_stack_trace.rs 37.83% 43 Missing and 3 partials ⚠️
crates/inspector/bytecode/src/lib.rs 11.53% 46 Missing ⚠️
crates/edr_provider/src/data.rs 75.86% 37 Missing and 5 partials ⚠️
crates/edr_solidity_tests/src/runner.rs 46.83% 41 Missing and 1 partial ⚠️
crates/edr_napi_core/src/spec.rs 0.00% 36 Missing ⚠️
crates/edr_solidity/src/tracing.rs 67.67% 30 Missing and 2 partials ⚠️
... and 35 more
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feat/geth-debugger    #1278      +/-   ##
======================================================
- Coverage               74.10%   66.80%   -7.31%     
======================================================
  Files                     437      442       +5     
  Lines                   74598    74893     +295     
  Branches                74598    74893     +295     
======================================================
- Hits                    55282    50031    -5251     
- Misses                  17285    23222    +5937     
+ Partials                 2031     1640     -391     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants