-
Notifications
You must be signed in to change notification settings - Fork 35
refactor: unify Solidity stack & call trace construction #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/geth-debugger
Are you sure you want to change the base?
Conversation
|
…n to edr_solidity This change consolidates trace construction logic by moving the conversion function from CallTraceArena (revm-inspectors) to NestedTrace into the edr_solidity crate, where NestedTrace is defined. Changes: - Add new module `edr_solidity::trace_arena_conversion` with the conversion function - Add revm and revm-inspectors dependencies to edr_solidity - Update Foundry's stack_trace.rs to use the conversion from edr_solidity - Remove duplicate conversion code from Foundry This enables both Foundry tests and the provider to use the same trace construction implementation, ensuring consistency across the codebase. The conversion function bridges the gap between the halt-reason-agnostic TracingInspector and the halt-reason-aware NestedTrace format.
8b2c0e0 to
4a2daf5
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/geth-debugger #1278 +/- ##
======================================================
- Coverage 74.10% 66.80% -7.31%
======================================================
Files 437 442 +5
Lines 74598 74893 +295
Branches 74598 74893 +295
======================================================
- Hits 55282 50031 -5251
- Misses 17285 23222 +5937
+ Partials 2031 1640 -391 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.