Share constants for filenames in contract deploy and faucet scripts#74
Open
JeremyBernier wants to merge 1 commit intoNomicFoundation:masterfrom
Open
Share constants for filenames in contract deploy and faucet scripts#74JeremyBernier wants to merge 1 commit intoNomicFoundation:masterfrom
JeremyBernier wants to merge 1 commit intoNomicFoundation:masterfrom
Conversation
JeremyBernier
force-pushed
the
file-constants
branch
from
ecca9cb to
897cfc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts folder and filenames in a
constants.tsfile to be shared acrossscripts/deploy.tsandtasks/faucet.ts.Currently these folder/filenames are hardcoded into both of these files. This PR reduces these folder/filenames to a single source of truth.