integrate user interruptions flow with ignition UI #6763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 31311ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
zoeyTM
changed the title
zoeyTM
force-pushed
the
ignition/ui-interruptions
branch
from
c9fae37 to
89c93f8
Compare
zoeyTM
force-pushed
the
ignition/ui-interruptions
branch
from
ccbb570 to
1be8ca3
Compare
kanej
reviewed
Jun 24, 2025
| @@ -6,7 +6,7 @@ import type { JournalMessage } from "../../execution/types/messages.js"; | |||
| * @beta | |||
| */ | |||
| export interface Journal { | |||
| record(message: JournalMessage): void; | |||
| record(message: JournalMessage): Promise<void>; | |||
There was a problem hiding this comment.
This needs to be reverted - we are intentional about recording to the journal being sync rather than async.
What is it that forced us here?
kanej
reviewed
Jun 24, 2025
Comment on lines
+16
to
+17
| // console.log(formattedMessage); | ||
|
|
There was a problem hiding this comment.
Suggested change
| // console.log(formattedMessage); |
kanej
reviewed
Jun 24, 2025
| // Maybe the math should be different here? | ||
| eventHandler.externalLinesWritten += formattedMessage.split("\n").length; | ||
|
|
||
| return "mock response"; |
There was a problem hiding this comment.
Is this placeholder code? Will it be updated with a subsequent PR?
kanej
reviewed
Jun 24, 2025
Comment on lines
+44
to
+45
| // console.log("Hello from the task's implementation of requestSecretInput"); | ||
|
|
There was a problem hiding this comment.
Suggested change
| // console.log("Hello from the task's implementation of requestSecretInput"); |
zoeyTM
force-pushed
the
ignition/ui-interruptions
branch
from
7465849 to
31311ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6682