Retain references to ImportDeconstructionSymbols instead of following to the aliased definition
#1510
+372
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an identifier resolves lexically to an `ImportDeconstructionSymbol` definition, register that instead of skipping it and registering to the actual aliased definition. This allows keeping better track of referenced imports. The conterpart is that we need to explicitly follow through the aliases whenever we need access to the actual definition, eg. when resolving types, members, etc.
|
teofr
reviewed
Jan 21, 2026
Contributor
teofr
left a comment
teofr
left a comment
There was a problem hiding this comment.
Mainly some questions to understand the change better.
crates/solidity/outputs/cargo/crate/src/backend/ir/ast/node_extensions/identifiers.rs
Outdated
Show resolved
Hide resolved
crates/solidity/outputs/cargo/crate/src/backend/ir/ast/node_extensions/identifiers.rs
Show resolved
Hide resolved
crates/solidity/outputs/cargo/crate/src/backend/passes/p3_linearise_contracts/mod.rs
Show resolved
Hide resolved
crates/solidity/outputs/cargo/crate/src/backend/passes/p4_type_definitions/resolution.rs
Show resolved
Hide resolved
…tensions/identifiers.rs Co-authored-by: Teodoro Freund <[email protected]>
teofr
reviewed
Jan 22, 2026
crates/solidity/outputs/cargo/crate/src/backend/ir/ast/node_extensions/identifiers.rs
Outdated
Show resolved
Hide resolved
teofr
approved these changes
Jan 23, 2026
Contributor
teofr
left a comment
teofr
left a comment
There was a problem hiding this comment.
Thanks! Sorry for the annoying nits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an identifier resolves lexically to an
ImportDeconstructionSymboldefinition, register that instead of skipping it and registering to the actual aliased definition. This allows keeping better track of referenced imports, which would otherwise appear to have no references pointing to them.The drawback is that we need to explicitly follow through the aliases whenever we need access to the actual definition, eg. when resolving types, members, etc.