[mlir] Lower logical not, bitwise not and ternary expressions

[abinavpp]

Requires matter-labs/solx-llvm#33

[Copilot]

Pull request overview

This PR extends the Solidity→MLIR lowering to cover additional expression forms used by the MLIR codegen backend, adding support for logical not (!), bitwise not (~), and conditional (ternary) expressions (c ? a : b), along with updated lit/semantic tests to validate the new lowering.

Changes:

• Add lowering for unary logical not and bitwise not in SolidityToMLIRPass::genExpr(UnaryOperation).
• Add lowering for conditional (ternary) expressions via scf.if yielding results, and wire it into expression dispatch.
• Update MLIR codegen lit tests and semantic tests to exercise !, ~, and ternary expressions.

Reviewed changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/lit/mlirCodegen/logical.sol	Extend logical test to include !a and update FileCheck output.
test/lit/mlirCodegen/if.sol	Add ternary function and expected MLIR (scf.if) checks.
test/lit/mlirCodegen/arith.sol	Add ~a usage and update expected IR patterns.
test/lit/mlirCodegen/EVM/logical.sol	Mirror logical-not coverage for the EVM pipeline checks.
test/lit/mlirCodegen/EVM/literals.sol	Update location/IR expectations after regen.
test/lit/mlirCodegen/EVM/if.sol	Mirror ternary coverage for the EVM pipeline checks.
test/libsolidity/semanticTests/mlir/logical.sol	Add semantic test coverage for ! on bool.
test/libsolidity/semanticTests/mlir/cf.sol	Add semantic test coverage for ternary expression.
test/libsolidity/semanticTests/mlir/arith.sol	Add semantic test coverage for ~ on uint.
libsolidity/codegen/mlir/SolidityToMLIR.cpp	Implement new lowering for !, ~, and ternary expressions.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[vladimirradosavljevic]

LGTM.
Could you please add these two lit tests:

  function tern_tuple(bool c, uint a, uint b, uint x, uint y) public pure returns (uint, uint) {
    return c ? (a, b) : (x, y);
  }

  function tern_const(bool c) public pure returns (uint) {
    return c ? 1 : 2;
  }

[PavelKopyl]

LGTM.