Handle empty dict if no git info is available#27
Closed
TomasTorsvik wants to merge 1 commit intoNorESMhub:noresmfrom
Closed
Handle empty dict if no git info is available#27TomasTorsvik wants to merge 1 commit intoNorESMhub:noresmfrom
TomasTorsvik wants to merge 1 commit intoNorESMhub:noresmfrom
Conversation
TomasTorsvik
changed the title
Collaborator
|
Thanks @TomasTorsvik . Looks good to me! However, I would suggest submit this fix to the NCAR/ADF repository, as this is a generic issue not with noresm-only. Otherwise, there might be conflicts in the future when we try merge with the NCAR/main. How do you think? |
Author
Yes, that's probably a better solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADF will fail if
get_git_info()returnsNone, which is the case if no git repository is found.This PR suggests a way to handle such a case, so that the processing can continue. Perhaps there are better ways, so please feel free to suggest alternative solutions.