[Backport #143] Fix callback vtable lifetime#144
Merged
Jauler merged 1 commit intomain-v0.28.3from Sep 9, 2025
Merged
Conversation
Jauler
changed the title
Jauler
force-pushed
the
LLT-6597_backport_movable_reference_fix
branch
from
b3a1c02 to
f37fc2a
Compare
Passing vtable struct via 'ref' may cause invalid memory accesses when GC defragments the heap and may move the vtable struct address. To prevent GC from moving vtable struct, pin vtable struct using GCHandle. To make the change work, update 'Reference' FFI type to use 'IntPtr' instead of 'ref'. Add some necessary casts from 'IntPtr' in callback implementation to make the code compile (the code previously used ref with concrete types). Signed-off-by: Kristupas Antanavičius <antanaviciuskristupas@gmail.com>
Jauler
force-pushed
the
LLT-6597_backport_movable_reference_fix
branch
from
f37fc2a to
751c112
Compare
dfetti
approved these changes
Sep 9, 2025
arg0d
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing vtable struct via 'ref' may cause invalid memory accesses when GC defragments the heap and may move the vtable struct address. To prevent GC from moving vtable struct, pin vtable struct using GCHandle.
To make the change work, update 'Reference' FFI type to use 'IntPtr' instead of 'ref'. Add some necessary casts from 'IntPtr' in callback implementation to make the code compile (the code previously used ref with concrete types).