Use PascalCase for record property names#153
Open
hadronzoo wants to merge 4 commits intoNordSecurity:mainfrom
Open
Use PascalCase for record property names#153hadronzoo wants to merge 4 commits intoNordSecurity:mainfrom
hadronzoo wants to merge 4 commits intoNordSecurity:mainfrom
Conversation
Record positional parameters now use PascalCase per C# naming conventions instead of @lowerCamelCase. Keywords are prefixed with @ only when necessary. - Add property_name filter for record/enum variant fields - Update RecordTemplate.cs to use property_name - Update EnumTemplate.cs to use property_name for variant fields - Update destroy_fields macro to use property_name - Add regression test fixture for issue-152 Signed-off-by: Joshua Griffith <Joshua.Griffith@fnf.com>
hadronzoo
force-pushed
the
fix/issue-152-pascalcase-record-properties
branch
from
b148e1a to
e4aadd4
Compare
hadronzoo
pushed a commit
to hadronzoo/uniffi-bindgen-cs
that referenced
this pull request
Jan 30, 2026
The PascalCase fix for record properties (PR NordSecurity#153) didn't extend to XML doc <param name=""> attributes. This caused documentation tools and IDEs to report "param name not found" warnings. Apply the property_name filter to param names in RecordTemplate.cs to match the actual PascalCase parameter names.
The PascalCase fix for record properties (PR NordSecurity#153) didn't extend to XML doc <param name=""> attributes. This caused documentation tools and IDEs to report "param name not found" warnings. Apply the property_name filter to param names in RecordTemplate.cs to match the actual PascalCase parameter names. Signed-off-by: Josh Griffith <josh.griffith@gmail.com>
hadronzoo
force-pushed
the
fix/issue-152-pascalcase-record-properties
branch
from
c86d956 to
2458cfb
Compare
C# keywords are lowercase (class, event), so PascalCase names (Class, Event) are valid identifiers and don't need @ prefix. The is_csharp_keyword function was checking for PascalCase strings which are never actually keywords. Signed-off-by: Josh Griffith <josh.griffith@gmail.com>
Signed-off-by: Josh Griffith <josh.griffith@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152