fix: copy bundled JLink to tmp before installing

[boundlesscalm]

This is necessary when installing the bundled JLink as it otherwise resides in a user created space which the root user is blocked from accessing.

[boundlesscalm]

We could technically just do this for all OS' but I don't see a reason for that except saving us like 3 lines of code.

[KievDevel]

Missing cleanup logic: will the installer be removed after installation from tmp? Or if app will be closed unexpectedly in between on the next launch of the launcher..?

[datenreisender]

@KievDevel @boundlesscalm: You could simplify the logic a bit and also get automatic cleanup with createDisposableTempDir(), as e.g. it is done at

pc-nrfconnect-launcher/src/main/apps/appChanges.ts

Lines 205 to 207 in cca24df

	using tempDir = createDisposableTempDir();
	await moveFile(appPath, path.join(tempDir.path, 'to-be-deleted'));
	};

.

With resource management you have to be a bit careful at what point the resource goes out of scope and thus can be disposed but I think this should be fine to use here. If you want to, I can also sketch an implementation or we can pair on it.

[datenreisender]

We could technically just do this for all OS' but I don't see a reason for that except saving us like 3 lines of code.

While slightly leaning towards the simpler code, both are fine for me: Doing this only for Linux or for all OS’.

[boundlesscalm]

We can't use the shared createDisposableTempDir since that creates a user owned directory and we run into the same issue.
But removing the file we just copied after installing it should not be an issue.

Not sure if we have to be so explicit in removing it anyway. It's in the /tmp/ folder which is expected to be automatically cleaned in ubuntu and most other OS-es.

[datenreisender]

We can't use the shared createDisposableTempDir since that creates a user owned directory and we run into the same issue.

Ah, I thought it is currently only a problem because it is mounted through FUSE, not because the ownership and permissions on the directory. We could also change ownership and permissions on the directory, seems like the easier approach to me, but another solution that works is also ok.

But removing the file we just copied after installing it should not be an issue.

Not sure if we have to be so explicit in removing it anyway. It's in the /tmp/ folder which is expected to be automatically cleaned in ubuntu and most other OS-es.

We do not strictly have to clean it up but I still think it is good practice to do it, also given that the temp folders are usually only wiped on startup.