Fix: Incorrect warning for nRF9151 modem FW files#568
Merged
datenreisender merged 2 commits intomainfrom Jan 19, 2026
Merged
Conversation
datenreisender
added
doc required
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the application incorrectly warns users about invalid filenames for nRF9151 modem firmware files that include variant suffixes like -ntn.
Changes:
- Updated the filename validation regex to support nRF9151 variant suffixes (e.g.,
mfw_nrf9151-ntn_1.0.0-1.alpha.zip) - Extracted validation logic into exported functions for better testability
- Added comprehensive test coverage for both nRF9160 and nRF91x1 firmware filename validation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/ModemUpdateDialogView.tsx | Refactored validation logic into exported functions and updated regex to accept nRF9151 variant filenames |
| src/components/tests/ModemUpdateDialogView-test.ts | Added new test file with comprehensive coverage for firmware filename validation |
| package.json | Bumped version to 4.7.2 |
| Changelog.md | Added entry documenting the fix for nRF9151 firmware filename validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KievDevel
approved these changes
Jan 16, 2026
greg-fer
requested changes
Jan 19, 2026
Changelog.md
Outdated
Comment on lines
+5
to
+7
| - Fixed incorrect warning "Unexpected file name detected" for nRF9151 modem | ||
| firmware files with variant suffixes (e.g., | ||
| `mfw_nrf9151-ntn_1.0.0-1.alpha.zip`). |
Contributor
There was a problem hiding this comment.
Suggested change
| - Fixed incorrect warning "Unexpected file name detected" for nRF9151 modem | |
| firmware files with variant suffixes (e.g., | |
| `mfw_nrf9151-ntn_1.0.0-1.alpha.zip`). | |
| - Issue with incorrect warning "Unexpected file name detected" that would appear for nRF9151 modem firmware files with variant suffixes (for example, `mfw_nrf9151-ntn_1.0.0-1.alpha.zip`). |
Contributor
Author
There was a problem hiding this comment.
I took your wording and just added line breaks to satisfy the linter.
Downloadable from https://www.nordicsemi.com/Products/Development-hardware/nRF9151-SMA-DK/Download?lang=en#infotabs there is currently a modem firmware file named "mfw_nrf9151-ntn_1.0.0-1.alpha.zip" and more like that will probably come. So the app should not warn that this is an invalid file name.
datenreisender
force-pushed
the
push-uxrroyuvqnvk
branch
from
0b36b9f to
e7310bf
Compare
greg-fer
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downloadable from https://www.nordicsemi.com/Products/Development-hardware/nRF9151-SMA-DK/Download?lang=en#infotabs there is currently a modem firmware file named "mfw_nrf9151-ntn_1.0.0-1.alpha.zip" and more like that will probably come. So the app should not warn that this is an invalid file name.