Skip to content

replace viewCsvExportButtonOption with viewCsvExportButton#15

Merged
clarktsiory merged 1 commit intoNormation:masterfrom
skaerg:view_csv_button
Jan 20, 2026
Merged

replace viewCsvExportButtonOption with viewCsvExportButton#15
clarktsiory merged 1 commit intoNormation:masterfrom
skaerg:view_csv_button

Conversation

@skaerg
Copy link
Contributor

@skaerg skaerg commented Jan 20, 2026

replace viewCsvExportButtonOption with viewCsvExportButton so that the latter can be used internally and take CsvExportOptions on every call

@skaerg skaerg requested a review from clarktsiory January 20, 2026 09:45
@skaerg skaerg marked this pull request as draft January 20, 2026 09:48
Copy link
Contributor

@clarktsiory clarktsiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, the viewCsvExportButtonOption is no longer needed, they are the same, so the private one can be removed and the public one can be used internally

@clarktsiory clarktsiory marked this pull request as ready for review January 20, 2026 09:49
@clarktsiory clarktsiory enabled auto-merge January 20, 2026 09:49
@clarktsiory clarktsiory marked this pull request as draft January 20, 2026 09:49
auto-merge was automatically disabled January 20, 2026 09:49

Pull request was converted to draft

@skaerg skaerg marked this pull request as ready for review January 20, 2026 09:50
@clarktsiory clarktsiory enabled auto-merge January 20, 2026 09:50
@skaerg skaerg changed the title viewCsvExportButton now takes CsvExportOptions instead of Model as argument replace viewCsvExportButtonOption with viewCsvExportButton Jan 20, 2026
@clarktsiory clarktsiory merged commit 0bf1c30 into Normation:master Jan 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants