Skip to content

Documentation. Update DAG library path in examples.#1089

Closed
stegrams wants to merge 1 commit intoNotAShelf:mainfrom
stegrams:patch-1
Closed

Documentation. Update DAG library path in examples.#1089
stegrams wants to merge 1 commit intoNotAShelf:mainfrom
stegrams:patch-1

Conversation

@stegrams
Copy link
Contributor

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@github-actions
Copy link

github-actions bot commented Aug 17, 2025

🚀 Live preview deployed from b6490ef

View it here:

Debug Information

Triggered by: stegrams

HEAD at: patch-1

Reruns: 1241

@NotAShelf
Copy link
Owner

I'm not sure why this change is necessary. As it stands we expose DAG functions from HM as lib.nvim.dag, not lib.hm.dag. If anything, the change should be to the latter.

@stegrams
Copy link
Contributor Author

Not exposed to my setup. Is there something that I need to do?

error: attribute 'nvim' missing
       at /nix/store/36jrfk8jf682l942k52kki2bkbx241zj-source/programs/nvf.nix:228:20:
          228|           inherit (lib.nvim.dag) entryAfter entryBefore;
             |                    ^
          229|         in {
       Did you mean one of nvs or trim?

@NotAShelf
Copy link
Owner

That is because you are not inheriting lib from the correct input. By default lib in your argset is from nixpkgs. NVF does not modify this one. inputs.nvf.lib is the correct one, which you may consider merging into a custom extended library with composeManyExtensions.

Either way I don't believe there is a lib.hm in Nixpkgs either?

@stegrams
Copy link
Contributor Author

Ok, I see now. I'll open again when it's right, with the proper explanation.

@stegrams stegrams closed this Aug 17, 2025
@github-actions
Copy link

✅ Preview has been deleted successfully!

@stegrams stegrams changed the title Documentation. DAG library examples from lib.dag to lib.hm.dag Documentation. Update DAG library path examples. Aug 17, 2025
@stegrams stegrams changed the title Documentation. Update DAG library path examples. Documentation. Update DAG library path in examples. Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants