Skip to content

Comments

languages/dockerfile: init#1104

Open
poseidon-rises wants to merge 3 commits intoNotAShelf:mainfrom
poseidon-rises:languages/dockerfile
Open

languages/dockerfile: init#1104
poseidon-rises wants to merge 3 commits intoNotAShelf:mainfrom
poseidon-rises:languages/dockerfile

Conversation

@poseidon-rises
Copy link
Contributor

Add dockerfile support using docker-language-server, dockerfmt, and hadolint.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@github-actions
Copy link

github-actions bot commented Aug 23, 2025

🚀 Live preview deployed from fde1338

View it here:

Debug Information

Triggered by: poseidon-rises

HEAD at: languages/dockerfile

Reruns: 1990

@horriblename horriblename force-pushed the v0.8 branch 2 times, most recently from 8b98f07 to ba9ce8b Compare September 13, 2025 07:23
github-actions bot pushed a commit that referenced this pull request Sep 16, 2025
@github-actions github-actions bot deleted the languages/dockerfile branch November 1, 2025 04:14
@poseidon-rises poseidon-rises restored the languages/dockerfile branch November 21, 2025 21:22
@github-actions github-actions bot deleted the languages/dockerfile branch December 1, 2025 04:42
horriblename
horriblename previously approved these changes Jan 18, 2026
Add dockerfile support using docker-language-server, dockerfmt, and
hadolint.
github-actions bot pushed a commit that referenced this pull request Jan 24, 2026
github-actions bot pushed a commit that referenced this pull request Jan 30, 2026
inherit (lib.nvim.types) mkGrammarOption diagnostics;
inherit (lib.nvim.attrsets) mapListToAttrs;

cfg = config.vim.languages.dockerfile;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just call it docker, as it supports dockerfile and compose.yml format.

];
filetypes = [
"dockerfile"
"yaml.docker-compose"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im pretty sure a compose.yml will be detected as yaml by default and not yaml.docker-compose, so prolly should be added.

"dockerfile"
"yaml.docker-compose"
];
root_markers = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should prolly include .git, as projects might be a git repo with Something.Dockerfile or simmilar. (ive seen it at work before)

@snoweuph
Copy link
Contributor

might I ask, whats currently blocking this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants