-
-
Notifications
You must be signed in to change notification settings - Fork 191
notes/obsidian-nvim: use a maintained fork #1217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ef9331b to
1e22b3b
Compare
1e22b3b to
8f5b9dc
Compare
8f5b9dc to
fdd26c7
Compare
b374a5a to
6688ef2
Compare
6688ef2 to
e234b83
Compare
8540844 to
c482a4f
Compare
|
@NotAShelf not urgent but the docs preview doesn't seem to update the option descriptions or the module docs I've changed/removed. I can just build stuff locally, but I figured I should let you know. |
c482a4f to
3ebe53d
Compare
bd31090 to
e61c2fa
Compare
I'm aware, but I haven't had time to investigate the issue. Especially given how truly archaic GHA truly is. I'm hoping to look into it, but I'm currently unavailable due to a variety of irl issues. This is obviously not a blocker, so I'll try to investigate whenever I have more time. If you wish to make sure this is not forgotten, feel free to create an issue :) |
Definitely focus on other more important things, yeah. Honestly being able to check before pushing is more my style. |
e61c2fa to
3c3b82d
Compare
3c3b82d to
a082544
Compare
Stable releases are regular and compatible with the latest packaged nvim versions from nixpkgs.
Obsidian essentially requires direct configuration, is not for a generic config example config. It isn't enabled now, so removing it should be fine.
a082544 to
11a7e95
Compare
Soliprem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failures seem related to another change. LGTM
| # It doesn't detect/choose this. | ||
| # Some pickers and completion plugins don't get detected correctly by the checkhealth, but they all work. | ||
| # Values taken from the [config's](https://github.com/obsidian-nvim/obsidian.nvim/blob/main/lua/obsidian/config/init.lua) valid ones. | ||
| picker.name = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really hate this but cannot think of a single better way of doing it. Curse the Nix language...
The current version of obsidian.nvim hasn't been updated in more than a year, isn't maintained, and hasn't kept up with new plugin compatibility.
This fork is the most popular one I found, is actively maintained, and has some nice newer features.
This PR converts nvf to use the fork instead, documenting the changes, which changes are immediately breaking (if you use the relevant options), and which options are still supported but deprecated.
I also removed some stale documentation and default configuration that didn't provide anything of value.
The configuration options are now entirely freeform.
A couple useful and suggested integrations were added, which I believe follow in the spirit of the project, automatically configuring stuff that is obvious given the context of the greater configuration.
Remaining WorkpluginOverride(Obsidian.optswarning is also new)noBuildPlugorbuildPlug.Is now set up as an exception in the wrapper setup.
diroption, to make it more visible, including how to fix itSanity Checking
blink.cmpandnvim-cmp(but not with both).snacks.picker,mini.pick,telescope.nvim, andfzf-lua.fzf-luagets detected by the:checkhealth.snacks.imageand related configuration.nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.