Skip to content

Conversation

@Ring-A-Ding-Ding-Baby
Copy link
Contributor

@Ring-A-Ding-Ding-Baby Ring-A-Ding-Ding-Baby commented Dec 13, 2025

This PR aligns the codelldb adapter setup with rustaceanvim’s built-in logic and adds the languages.rust.dap.backend option to choose between the codelldb and lldb-dap adapters.

Why?

According to the rustaceanvim source code,
codelldb is preferred over LLVM’s lldb-dap for the reasons described in the
“Using codelldb for debugging” section of the README.

These changes provide a better out-of-the-box experience for Rust developers, without the need for custom Lua patches to make rustaceanvim behave as intended.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@github-actions
Copy link

github-actions bot commented Dec 13, 2025

🚀 Live preview deployed from 13b3916

View it here:

Debug Information

Triggered by: Ring-A-Ding-Ding-Baby

HEAD at: fix/rustaceanvim-dap-adapter

Reruns: 1681

Align codelldb adapter setup with rustaceanvim’s built-in logic.
Add languages.rust.dap.backend option to choose between codelldb
and lldb-dap adapters.
@Ring-A-Ding-Ding-Baby Ring-A-Ding-Ding-Baby force-pushed the fix/rustaceanvim-dap-adapter branch from a1d04fc to 13b3916 Compare December 13, 2025 12:23
github-actions bot pushed a commit that referenced this pull request Dec 13, 2025
Copy link
Collaborator

@horriblename horriblename left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@horriblename horriblename merged commit 2fe8be4 into NotAShelf:main Dec 13, 2025
26 of 28 checks passed
@github-actions
Copy link

✅ Preview has been deleted successfully!

Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi the release notes are in the wrong file

I'll fix this in a separate PR.

@Ring-A-Ding-Ding-Baby
Copy link
Contributor Author

My bad!
And thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants