-
-
Notifications
You must be signed in to change notification settings - Fork 191
make toggleterm open map acutally toggle the terminal #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Soliprem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs the changelog entry. Did you already test it already? (in general, for the future, I recommend you make use of the checklist. It makes reviewing a lot faster :3. Especially for bigger PRs, if the checklist's empty, I kind of assume it's not ready for review because the change wasn't tested etc...)
|
Yeah sorry for that. The change was so minimal I thought I could get away with skipping the rest. I run through the checklist now and added the changelog entry. |
Soliprem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work!
Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.