Skip to content

Conversation

@Libadoxon
Copy link
Contributor

@Libadoxon Libadoxon commented Dec 16, 2025

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

🚀 Live preview deployed from a80993f

View it here:

Debug Information

Triggered by: Soliprem

HEAD at: patch-1

Reruns: 1736

Copy link
Collaborator

@Soliprem Soliprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs the changelog entry. Did you already test it already? (in general, for the future, I recommend you make use of the checklist. It makes reviewing a lot faster :3. Especially for bigger PRs, if the checklist's empty, I kind of assume it's not ready for review because the change wasn't tested etc...)

@Libadoxon
Copy link
Contributor Author

Yeah sorry for that. The change was so minimal I thought I could get away with skipping the rest. I run through the checklist now and added the changelog entry.

github-actions bot pushed a commit that referenced this pull request Dec 20, 2025
@Libadoxon Libadoxon requested a review from Soliprem December 20, 2025 21:34
@horriblename horriblename enabled auto-merge (squash) December 21, 2025 12:15
Copy link
Collaborator

@Soliprem Soliprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

@horriblename horriblename merged commit b1b8794 into NotAShelf:main Dec 21, 2025
13 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants