language/go: add golangci-lint for extra diagnostics

[snoweuph]

Adds golanci-lint for more diagnostics in go.

works just fine with severity mapping of the config file:

Sanity Checking

• I have updated the changelog as per my changes
• I have tested, and self-reviewed my code
• My changes fit guidelines found in hacking nvf
• Style and consistency
  • I ran Alejandra to format my code (nix fmt)
  • My code conforms to the editorconfig configuration of the project
  • My changes are consistent with the rest of the codebase
• If new changes are particularly complex:
  • My code includes comments in particularly complex areas
  • I have added a section in the manual
  • (For breaking changes) I have included a migration guide
• Package(s) built:
  • .#nix (default package)
  • .#maximal
  • .#docs-html (manual, must build)
  • .#docs-linkcheck (optional, please build if adding links)
• Tested on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin

---

Add a 👍 reaction to pull requests you find important.

[github-actions]

🚀 Live preview deployed from fde1338

View it here:

Debug Information

Triggered by: snoweuph

HEAD at: feature/go

Reruns: 2001

[snoweuph]

I plan on adding a few more common go diagnostic tools in followup MRs.
Is there a timeline, when the 0.9 release will be cut?
I would like to get them all into it :D

[snoweuph]

🚀 Live preview deployed from fde1338

View it here:
Debug Information

[horriblename]

Is there a timeline, when the 0.9 release will be cut?

not anytime soon, we usually only make a release when we have breaking changes, and we don't have any planned at the moment (unless @NotAShelf has a release schedule he didn't tell me about)

[snoweuph]

i gonna test the changes i id again, just to be sure

[snoweuph]

still works as expected.
@horriblename ready for re-review

[snoweuph]

this is a great learning experince for me :D

adding a few of the other missing diags from my list, should go much faster, in the future :D

[horriblename]

thanks!