Skip to content

Comments

spell: ignore terminal by default#1388

Merged
NotAShelf merged 2 commits intoNotAShelf:mainfrom
horriblename:ignore-spell-term
Feb 17, 2026
Merged

spell: ignore terminal by default#1388
NotAShelf merged 2 commits intoNotAShelf:mainfrom
horriblename:ignore-spell-term

Conversation

@horriblename
Copy link
Collaborator

@horriblename horriblename commented Feb 3, 2026

can't believe this isn't the default

fixes #1379

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@horriblename horriblename changed the title Ignore terminal for spell check spell: ignore terminal by default Feb 3, 2026
github-actions bot pushed a commit that referenced this pull request Feb 3, 2026
github-actions bot pushed a commit that referenced this pull request Feb 3, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

🚀 Live preview deployed from 99bf160

View it here:

Debug Information

Triggered by: horriblename

HEAD at: ignore-spell-term

Reruns: 2118

@snoweuph
Copy link
Contributor

snoweuph commented Feb 3, 2026

thanks :D

can't believe this isn't the default

me neither

@snoweuph
Copy link
Contributor

snoweuph commented Feb 7, 2026

I hope another maintainer can review this 👀

had i opened the MR, you could have reviewed it 😭

@NotAShelf
Copy link
Owner

I'm going to review tomorrow. @horriblename plz fix merge conflict <3

@NotAShelf
Copy link
Owner

he did, in fact, not fix merge conflict...

@snoweuph
Copy link
Contributor

:/

@snoweuph
Copy link
Contributor

I would rebase it, but its not my MR :////

@NotAShelf
Copy link
Owner

I really didn't want to do this by hand, whatever.

@NotAShelf NotAShelf enabled auto-merge February 14, 2026 23:39
@horriblename
Copy link
Collaborator Author

oopsies

github-actions bot pushed a commit that referenced this pull request Feb 14, 2026
github-actions bot pushed a commit that referenced this pull request Feb 17, 2026
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR pushed my grandma off the stairs

@NotAShelf NotAShelf merged commit 0c650e0 into NotAShelf:main Feb 17, 2026
14 checks passed
@horriblename horriblename deleted the ignore-spell-term branch February 18, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't disable spellchecking in term buffers, as they don't have a filetype

3 participants