Conversation
snoweuph
requested review from
NotAShelf,
Soliprem and
horriblename
as code owners
| impl = mkOption { | ||
| description = "impl binary to use"; | ||
| type = str; | ||
| default = getExe pkgs.impl; |
There was a problem hiding this comment.
@horriblename, think we can just patch it in for now with an increased tag? looking at https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/im/impl/package.nix#L9 it doesn't seem to be that complicated of a package, and I don't see any reason in the src, why it shouldn't build anymore, after bumping the tag.
OR is such a thing, something we don't do at nvf?
There was a problem hiding this comment.
Looks like its soon updated on nixpkgs: NixOS/nixpkgs#488245
though I guess we will need to wait a bit before a hydra build provides it on usntable :D
There was a problem hiding this comment.
its merged upstream and hydra build is also done on unstable channel
There was a problem hiding this comment.
Opened Upstream Issue, as the problem was not impl beeing an older version, as its now at 1.5.0 as well olexsmir/gopher.nvim#134
| go = mkOption { | ||
| description = "go binary to use"; | ||
| type = str; | ||
| default = "go"; |
There was a problem hiding this comment.
normally projects provide their own go version (via PATH) with for example a devshell.
i didn't want to leave one of the command options out though.
As why the the others are pointing at nix packages: you might not have them in your path, and the plugin will break without the bins.
And everybody developing with go, needs to have some go to use, but not everybody has the extra bins installed.
There was a problem hiding this comment.
its basicly the same as we do with rust, or any other language
snoweuph
force-pushed
the
feat/go-extra
branch
from
8b47f75 to
34a0dce
Compare
snoweuph
force-pushed
the
feat/go-extra
branch
from
34a0dce to
11660fe
Compare
|
rebased -> showing I didnt forgot this and for my future sanity :D |
snoweuph
force-pushed
the
feat/go-extra
branch
from
11660fe to
644ed34
Compare
|
rebased. still waiting for plugin upstream issue to get resolved |
1 participant
add gopher.nvim
I really want
gomodifytagsandimplsupport, but besides go.nvim, which is heavy and this, the single goal plugins are all unmaintained.Waiting for: NixOS/nixpkgs#488212 as with this mr, the
:GoImplwill fail, due to nixpkgs beeing outdatedSanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.