Skip to content

Comments

language/hcl: fix #1350#1405

Merged
horriblename merged 1 commit intoNotAShelf:mainfrom
snoweuph:fix/hcl
Feb 18, 2026
Merged

language/hcl: fix #1350#1405
horriblename merged 1 commit intoNotAShelf:mainfrom
snoweuph:fix/hcl

Conversation

@snoweuph
Copy link
Contributor

@snoweuph snoweuph commented Feb 8, 2026

Just ran across #1350 when trying out some of the other modules, so here's the patch.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@snoweuph
Copy link
Contributor Author

snoweuph commented Feb 8, 2026

for now just a simple patch.

NotAShelf suggested:

Should be a trivial fix. I'm going to add a module option for comment.nvim that helps register comment formats per-ft, and use the module option in the HCL module. This way disabling the module will not have any side effects on eval.

Currently working on something else, but I'd be happy to review a PR. If not, I'll get on this later today.

though, as he has no time, lets use this simple patch for now :D
I'm not deep enough yet to implement what he suggested :3

github-actions bot pushed a commit that referenced this pull request Feb 8, 2026
@github-actions
Copy link

github-actions bot commented Feb 8, 2026

🚀 Live preview deployed from 9d1cec1

View it here:

Debug Information

Triggered by: horriblename

HEAD at: fix/hcl

Reruns: 2127

@snoweuph
Copy link
Contributor Author

rebased

github-actions bot pushed a commit that referenced this pull request Feb 15, 2026
@snoweuph snoweuph requested a review from NotAShelf February 17, 2026 00:48
github-actions bot pushed a commit that referenced this pull request Feb 17, 2026
@horriblename horriblename enabled auto-merge (squash) February 18, 2026 11:00
@horriblename horriblename merged commit 0c4fecd into NotAShelf:main Feb 18, 2026
13 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 18, 2026
@snoweuph snoweuph deleted the fix/hcl branch February 18, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants