Skip to content

languages/odin: disable dap notification spam#1424

Merged
horriblename merged 2 commits intoNotAShelf:mainfrom
snoweuph:feat/odin-spam
Feb 21, 2026
Merged

languages/odin: disable dap notification spam#1424
horriblename merged 2 commits intoNotAShelf:mainfrom
snoweuph:feat/odin-spam

Conversation

@snoweuph
Copy link
Contributor

@snoweuph snoweuph commented Feb 20, 2026

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@snoweuph
Copy link
Contributor Author

snoweuph commented Feb 20, 2026

still waiting on my local builds for everything i can do to finish :D
image

@snoweuph snoweuph marked this pull request as ready for review February 20, 2026 23:40
@snoweuph
Copy link
Contributor Author

Done :D

github-actions bot pushed a commit that referenced this pull request Feb 20, 2026
@github-actions
Copy link

github-actions bot commented Feb 20, 2026

🚀 Live preview deployed from cc76be2

View it here:

Debug Information

Triggered by: horriblename

HEAD at: feat/odin-spam

Reruns: 2165

@horriblename
Copy link
Collaborator

that should be a setupOpts instead

@snoweuph
Copy link
Contributor Author

that should be a setupOpts instead

I would prefer lazy loading the plugins only on odin files, but looking through all existing plugins I didn't find any doing that they all use after or anwywhere none use filetpye directly?
but yea, I should prolly add setupOpts

@horriblename
Copy link
Collaborator

if it loads under 1ms I personally wouldn't bother lazy loading, but you can do it if you want it

NotAShelf
NotAShelf previously approved these changes Feb 21, 2026
@NotAShelf
Copy link
Owner

NotAShelf commented Feb 21, 2026

We can move to setupOpts in a different PR that revisits debuggin modules imo.

@horriblename
Copy link
Collaborator

We can move to setupOpts in a different PR that revisits debuggin modules imo.

sure

@horriblename horriblename enabled auto-merge (squash) February 21, 2026 04:33
@horriblename horriblename enabled auto-merge (squash) February 21, 2026 04:33
github-actions bot pushed a commit that referenced this pull request Feb 21, 2026
@horriblename horriblename merged commit 2174c17 into NotAShelf:main Feb 21, 2026
14 checks passed
@snoweuph
Copy link
Contributor Author

if it loads under 1ms I personally wouldn't bother lazy loading, but you can do it if you want it

It gives anoying startup notifications, because itselfe is not lazy. simmilar to to the java dap, but that one only starts loading when you open the first java file.

@snoweuph
Copy link
Contributor Author

We can move to setupOpts in a different PR that revisits debuggin modules imo.

what do you mean? like in general for all daps?

@snoweuph snoweuph deleted the feat/odin-spam branch February 21, 2026 08:30
@NotAShelf
Copy link
Owner

We can move to setupOpts in a different PR that revisits debuggin modules imo.

what do you mean? like in general for all daps?

Ideally yes, for all DAPs but the debugger modules are in need of the same love we've shown to LSPs imo.

@snoweuph
Copy link
Contributor Author

@NotAShelf are all comunnications for this project through discussions, issues and PRs, or is there also something like a matrix room?

@NotAShelf
Copy link
Owner

There's a discord group chat and a matrix room, though we do use PRs for serious communication and the discord group chat for... shitposting...

You can join the matrix room here

@snoweuph
Copy link
Contributor Author

There's a discord group chat and a matrix room, though we do use PRs for serious communication and the discord group chat for... shitposting...

You can join the matrix room here

shitposting sounds awesome :trollface:

daynyxx pushed a commit to daynyxx/nvf that referenced this pull request Feb 25, 2026
* languages/odin: disable dap notification spam

---------

Co-authored-by: Ching Pei Yang <59727193+horriblename@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants