neovim: gradually deprecate shorthand vim.* aliases to vim.options and vim.globals#480
Merged
neovim: gradually deprecate shorthand vim.* aliases to vim.options and vim.globals#480
vim.* aliases to vim.options and vim.globals#480Conversation
horriblename
reviewed
Dec 2, 2024
Deprecate shorthand EditorConfig toggle, and encourage the more powerful `vim.globals` option.
Prefer the type-safe `vim.options` equivalent.
NotAShelf
force-pushed
the
more-option-stuff
branch
from
5afcf67 to
66005a5
Compare
1 task
As the mouse option in neovim allows combining those values.
horriblename
approved these changes
Jan 10, 2025
diniamo
suggested changes
Jan 10, 2025
Comment on lines
+240
to
+248
| signcolumn = mkOption { | ||
| type = either str bool; | ||
| default = true; | ||
| apply = x: | ||
| if isBool x | ||
| then toVimBool x # convert to a yes/no str | ||
| else x; | ||
| description = "Show the sign column"; | ||
| }; |
Contributor
There was a problem hiding this comment.
Please just have it be a string, and remove the toVimBool function
| ''; | ||
|
|
||
| example = literalExpression ''"$${builtins.readFile ./my-lua-config-pre.lua}"''; | ||
| example = literalExpression ''''${builtins.readFile ./my-lua-config-pre.lua}''; |
Contributor
There was a problem hiding this comment.
Suggested change
| example = literalExpression ''''${builtins.readFile ./my-lua-config-pre.lua}''; | |
| example = literalExpression "\${builtins.readFile ./my-lua-config-pre.lua}"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slowly deprecates top-level options that used to set Neovim's
vim.optoptions in favor ofvim.optionsandvim.globalsmodule options.